From: Alexey Starikovskiy <aystarik@gmail.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: lenb@kernel.org, astarikovskiy@suse.de,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] acpi/battery.c: make 2 functions static
Date: Sat, 01 Mar 2008 21:26:41 +0300 [thread overview]
Message-ID: <47C99FE1.8080206@gmail.com> (raw)
In-Reply-To: <20080301161902.GN25835@cs181133002.pp.htv.fi>
May I keep them inline?
Thanks,
Alex.
Adrian Bunk wrote:
> This patch makes the following functions static instead of global inline:
> - acpi_battery_present()
> - acpi_battery_units()
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> drivers/acpi/battery.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> 9cfc2b0a3162d8e2f23537faefb6937c97513f38 foobar
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index f6215e8..d941c5a 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -116,7 +116,7 @@ struct acpi_battery {
>
> #define to_acpi_battery(x) container_of(x, struct acpi_battery, bat);
>
> -inline int acpi_battery_present(struct acpi_battery *battery)
> +static int acpi_battery_present(struct acpi_battery *battery)
> {
> return battery->device->status.battery_present;
> }
> @@ -235,7 +235,7 @@ static enum power_supply_property energy_battery_props[] = {
> #endif
>
> #ifdef CONFIG_ACPI_PROCFS_POWER
> -inline char *acpi_battery_units(struct acpi_battery *battery)
> +static char *acpi_battery_units(struct acpi_battery *battery)
> {
> return (battery->power_unit)?"mA":"mW";
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-03-01 18:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 16:19 [2.6 patch] acpi/battery.c: make 2 functions static Adrian Bunk
2008-03-01 18:26 ` Alexey Starikovskiy [this message]
2008-03-01 18:35 ` Adrian Bunk
2008-03-01 18:42 ` Alexey Starikovskiy
2008-03-01 18:45 ` Adrian Bunk
2008-03-03 8:57 ` Ingo Molnar
2008-03-03 9:13 ` Adrian Bunk
2008-03-03 9:17 ` Ingo Molnar
2008-03-03 9:31 ` Sam Ravnborg
2008-03-03 9:48 ` Adrian Bunk
2008-03-03 10:39 ` Ingo Molnar
2008-03-03 11:34 ` Adrian Bunk
2008-03-03 11:45 ` Ingo Molnar
2008-03-03 12:02 ` Adrian Bunk
2008-03-03 12:10 ` Ingo Molnar
2008-03-03 12:29 ` Adrian Bunk
2008-03-03 12:50 ` Ingo Molnar
2008-03-03 14:54 ` Adrian Bunk
2008-03-03 15:01 ` Adrian Bunk
2008-03-04 13:16 ` Ingo Molnar
2008-03-04 13:47 ` Adrian Bunk
2008-03-04 14:22 ` Ingo Molnar
2008-03-04 14:36 ` Jörn Engel
2008-03-04 14:45 ` Ingo Molnar
2008-03-03 12:13 ` [patch] x86: phase out forced inlining Ingo Molnar
2008-03-03 14:56 ` Sam Ravnborg
2008-03-04 16:46 ` Ingo Molnar
2008-03-04 18:07 ` Harvey Harrison
2008-03-04 18:09 ` H. Peter Anvin
2008-03-04 18:14 ` Harvey Harrison
2008-03-04 18:18 ` Harvey Harrison
2008-03-03 15:01 ` Arjan van de Ven
2008-03-03 15:58 ` Harvey Harrison
2008-03-04 6:42 ` Andrew Morton
2008-03-04 7:32 ` Ingo Molnar
2008-03-04 8:00 ` Andrew Morton
2008-03-04 9:50 ` Andi Kleen
2008-03-04 8:03 ` Sam Ravnborg
2008-03-04 8:38 ` Andrew Morton
2008-03-03 9:45 ` [2.6 patch] acpi/battery.c: make 2 functions static Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C99FE1.8080206@gmail.com \
--to=aystarik@gmail.com \
--cc=astarikovskiy@suse.de \
--cc=bunk@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox