* [PATCH] ACPI: disable stray gpe correctly
@ 2008-03-10 2:04 Zhang, Rui
2008-03-11 6:06 ` Len Brown
0 siblings, 1 reply; 8+ messages in thread
From: Zhang, Rui @ 2008-03-10 2:04 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi, Lin, Ming M, robert.moore, davej
Disable stray GPE correctly
https://bugzilla.redhat.com/show_bug.cgi?id=251744
http://bugzilla.kernel.org/show_bug.cgi?id=6217
Sighed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/acpi/events/evgpe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6/drivers/acpi/events/evgpe.c
===================================================================
--- linux-2.6.orig/drivers/acpi/events/evgpe.c
+++ linux-2.6/drivers/acpi/events/evgpe.c
@@ -248,7 +248,8 @@ acpi_status acpi_ev_disable_gpe(struct a
ACPI_FUNCTION_TRACE(ev_disable_gpe);
- if (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK)) {
+ if (gpe_event_info->flags &&
+ (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK))) {
return_ACPI_STATUS(AE_OK);
}
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ACPI: disable stray gpe correctly
2008-03-10 2:04 [PATCH] ACPI: disable stray gpe correctly Zhang, Rui
@ 2008-03-11 6:06 ` Len Brown
2008-03-12 19:55 ` Chuck Ebbert
0 siblings, 1 reply; 8+ messages in thread
From: Len Brown @ 2008-03-11 6:06 UTC (permalink / raw)
To: Zhang, Rui; +Cc: linux-acpi, Lin, Ming M, robert.moore, davej
applied.
thanks,
-Len
On Sunday 09 March 2008, Zhang, Rui wrote:
> Disable stray GPE correctly
> https://bugzilla.redhat.com/show_bug.cgi?id=251744
> http://bugzilla.kernel.org/show_bug.cgi?id=6217
>
> Sighed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
> drivers/acpi/events/evgpe.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/acpi/events/evgpe.c
> ===================================================================
> --- linux-2.6.orig/drivers/acpi/events/evgpe.c
> +++ linux-2.6/drivers/acpi/events/evgpe.c
> @@ -248,7 +248,8 @@ acpi_status acpi_ev_disable_gpe(struct a
>
> ACPI_FUNCTION_TRACE(ev_disable_gpe);
>
> - if (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK)) {
> + if (gpe_event_info->flags &&
> + (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK))) {
> return_ACPI_STATUS(AE_OK);
> }
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ACPI: disable stray gpe correctly
2008-03-11 6:06 ` Len Brown
@ 2008-03-12 19:55 ` Chuck Ebbert
2008-03-12 20:09 ` Len Brown
0 siblings, 1 reply; 8+ messages in thread
From: Chuck Ebbert @ 2008-03-12 19:55 UTC (permalink / raw)
To: Len Brown; +Cc: Zhang, Rui, linux-acpi, Lin, Ming M, robert.moore, davej
On 03/11/2008 02:06 AM, Len Brown wrote:
> applied.
>
> thanks,
> -Len
>
> On Sunday 09 March 2008, Zhang, Rui wrote:
>> Disable stray GPE correctly
>> https://bugzilla.redhat.com/show_bug.cgi?id=251744
>> http://bugzilla.kernel.org/show_bug.cgi?id=6217
>>
>> Sighed-off-by: Zhang Rui <rui.zhang@intel.com>
>> ---
>> drivers/acpi/events/evgpe.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> Index: linux-2.6/drivers/acpi/events/evgpe.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/acpi/events/evgpe.c
>> +++ linux-2.6/drivers/acpi/events/evgpe.c
>> @@ -248,7 +248,8 @@ acpi_status acpi_ev_disable_gpe(struct a
>>
>> ACPI_FUNCTION_TRACE(ev_disable_gpe);
>>
>> - if (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK)) {
>> + if (gpe_event_info->flags &&
>> + (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK))) {
>> return_ACPI_STATUS(AE_OK);
>> }
>>
Causes ACPI battery problems...
https://bugzilla.redhat.com/show_bug.cgi?id=436959
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ACPI: disable stray gpe correctly
2008-03-12 19:55 ` Chuck Ebbert
@ 2008-03-12 20:09 ` Len Brown
2008-03-12 21:59 ` Moore, Robert
2008-03-14 21:48 ` Moore, Robert
0 siblings, 2 replies; 8+ messages in thread
From: Len Brown @ 2008-03-12 20:09 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: Zhang, Rui, linux-acpi, Lin, Ming M, robert.moore, davej
> > On Sunday 09 March 2008, Zhang, Rui wrote:
> >> Disable stray GPE correctly
> >> https://bugzilla.redhat.com/show_bug.cgi?id=251744
> >> http://bugzilla.kernel.org/show_bug.cgi?id=6217
> >>
> >> Sighed-off-by: Zhang Rui <rui.zhang@intel.com>
> >> ---
> >> drivers/acpi/events/evgpe.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> Index: linux-2.6/drivers/acpi/events/evgpe.c
> >> ===================================================================
> >> --- linux-2.6.orig/drivers/acpi/events/evgpe.c
> >> +++ linux-2.6/drivers/acpi/events/evgpe.c
> >> @@ -248,7 +248,8 @@ acpi_status acpi_ev_disable_gpe(struct a
> >>
> >> ACPI_FUNCTION_TRACE(ev_disable_gpe);
> >>
> >> - if (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK)) {
> >> + if (gpe_event_info->flags &&
> >> + (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK))) {
> >> return_ACPI_STATUS(AE_OK);
> >> }
> >>
>
> Causes ACPI battery problems...
>
> https://bugzilla.redhat.com/show_bug.cgi?id=436959
Okay, i've droppped it until 436959 can be figured out.
thanks Chuck,
-Len
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] ACPI: disable stray gpe correctly
2008-03-12 20:09 ` Len Brown
@ 2008-03-12 21:59 ` Moore, Robert
2008-03-12 22:35 ` Chuck Ebbert
2008-03-14 21:48 ` Moore, Robert
1 sibling, 1 reply; 8+ messages in thread
From: Moore, Robert @ 2008-03-12 21:59 UTC (permalink / raw)
To: Len Brown, Chuck Ebbert; +Cc: Zhang, Rui, linux-acpi, Lin, Ming M, davej
This patch looked fairly benign to me, so I've committed it to the
ACPICA core for the next release this week.
The comment I added for the patch looks like this:
/*
* Ignore this if the GPE is valid and not enabled.
*
* Flags is only zero if GPE is neither enabled or disabled -- it
may
* be a spurious or stray GPE -- disable it in the default case
below.
*/
if (GpeEventInfo->Flags &&
(!(GpeEventInfo->Flags & ACPI_GPE_ENABLE_MASK)))
{
return_ACPI_STATUS (AE_OK);
}
If there are problems, I will back it out. Please let me know ASAP what
the issue is in 436959.
Thanks,
Bob
>-----Original Message-----
>From: Len Brown [mailto:lenb@kernel.org]
>Sent: Wednesday, March 12, 2008 1:10 PM
>To: Chuck Ebbert
>Cc: Zhang, Rui; linux-acpi; Lin, Ming M; Moore, Robert;
davej@redhat.com
>Subject: Re: [PATCH] ACPI: disable stray gpe correctly
>
>
>> > On Sunday 09 March 2008, Zhang, Rui wrote:
>> >> Disable stray GPE correctly
>> >> https://bugzilla.redhat.com/show_bug.cgi?id=251744
>> >> http://bugzilla.kernel.org/show_bug.cgi?id=6217
>> >>
>> >> Sighed-off-by: Zhang Rui <rui.zhang@intel.com>
>> >> ---
>> >> drivers/acpi/events/evgpe.c | 3 ++-
>> >> 1 file changed, 2 insertions(+), 1 deletion(-)
>> >>
>> >> Index: linux-2.6/drivers/acpi/events/evgpe.c
>> >>
===================================================================
>> >> --- linux-2.6.orig/drivers/acpi/events/evgpe.c
>> >> +++ linux-2.6/drivers/acpi/events/evgpe.c
>> >> @@ -248,7 +248,8 @@ acpi_status acpi_ev_disable_gpe(struct a
>> >>
>> >> ACPI_FUNCTION_TRACE(ev_disable_gpe);
>> >>
>> >> - if (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK)) {
>> >> + if (gpe_event_info->flags &&
>> >> + (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK))) {
>> >> return_ACPI_STATUS(AE_OK);
>> >> }
>> >>
>>
>> Causes ACPI battery problems...
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=436959
>
>Okay, i've droppped it until 436959 can be figured out.
>
>thanks Chuck,
>-Len
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ACPI: disable stray gpe correctly
2008-03-12 21:59 ` Moore, Robert
@ 2008-03-12 22:35 ` Chuck Ebbert
0 siblings, 0 replies; 8+ messages in thread
From: Chuck Ebbert @ 2008-03-12 22:35 UTC (permalink / raw)
To: Moore, Robert; +Cc: Len Brown, Zhang, Rui, linux-acpi, Lin, Ming M, davej
On 03/12/2008 05:59 PM, Moore, Robert wrote:
> This patch looked fairly benign to me, so I've committed it to the
> ACPICA core for the next release this week.
>
> The comment I added for the patch looks like this:
>
> /*
> * Ignore this if the GPE is valid and not enabled.
> *
> * Flags is only zero if GPE is neither enabled or disabled -- it
> may
> * be a spurious or stray GPE -- disable it in the default case
> below.
> */
> if (GpeEventInfo->Flags &&
> (!(GpeEventInfo->Flags & ACPI_GPE_ENABLE_MASK)))
> {
> return_ACPI_STATUS (AE_OK);
> }
>
>
> If there are problems, I will back it out. Please let me know ASAP what
> the issue is in 436959.
>
The battery information is all wrong with the patch applied.
The battery model changes from 'NBP6A24A1' to 'Main', all the capacities
are wrong, and it reports that the battery is discharging when it is fully
charged and the machine is running on AC.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] ACPI: disable stray gpe correctly
2008-03-12 20:09 ` Len Brown
2008-03-12 21:59 ` Moore, Robert
@ 2008-03-14 21:48 ` Moore, Robert
2008-03-17 2:09 ` Zhang, Rui
1 sibling, 1 reply; 8+ messages in thread
From: Moore, Robert @ 2008-03-14 21:48 UTC (permalink / raw)
To: Moore, Robert, Len Brown, Chuck Ebbert
Cc: Zhang, Rui, linux-acpi, Lin, Ming M, davej
I'm going to back this out until the reported problem is resolved.
Bob
>-----Original Message-----
>From: Moore, Robert
>Sent: Wednesday, March 12, 2008 2:59 PM
>To: 'Len Brown'; Chuck Ebbert
>Cc: Zhang, Rui; linux-acpi; Lin, Ming M; davej@redhat.com
>Subject: RE: [PATCH] ACPI: disable stray gpe correctly
>
>This patch looked fairly benign to me, so I've committed it to the
ACPICA
>core for the next release this week.
>
>The comment I added for the patch looks like this:
>
> /*
> * Ignore this if the GPE is valid and not enabled.
> *
> * Flags is only zero if GPE is neither enabled or disabled -- it
may
> * be a spurious or stray GPE -- disable it in the default case
below.
> */
> if (GpeEventInfo->Flags &&
> (!(GpeEventInfo->Flags & ACPI_GPE_ENABLE_MASK)))
> {
> return_ACPI_STATUS (AE_OK);
> }
>
>
>If there are problems, I will back it out. Please let me know ASAP what
the
>issue is in 436959.
>
>Thanks,
>Bob
>
>
>
>>-----Original Message-----
>>From: Len Brown [mailto:lenb@kernel.org]
>>Sent: Wednesday, March 12, 2008 1:10 PM
>>To: Chuck Ebbert
>>Cc: Zhang, Rui; linux-acpi; Lin, Ming M; Moore, Robert;
davej@redhat.com
>>Subject: Re: [PATCH] ACPI: disable stray gpe correctly
>>
>>
>>> > On Sunday 09 March 2008, Zhang, Rui wrote:
>>> >> Disable stray GPE correctly
>>> >> https://bugzilla.redhat.com/show_bug.cgi?id=251744
>>> >> http://bugzilla.kernel.org/show_bug.cgi?id=6217
>>> >>
>>> >> Sighed-off-by: Zhang Rui <rui.zhang@intel.com>
>>> >> ---
>>> >> drivers/acpi/events/evgpe.c | 3 ++-
>>> >> 1 file changed, 2 insertions(+), 1 deletion(-)
>>> >>
>>> >> Index: linux-2.6/drivers/acpi/events/evgpe.c
>>> >>
===================================================================
>>> >> --- linux-2.6.orig/drivers/acpi/events/evgpe.c
>>> >> +++ linux-2.6/drivers/acpi/events/evgpe.c
>>> >> @@ -248,7 +248,8 @@ acpi_status acpi_ev_disable_gpe(struct a
>>> >>
>>> >> ACPI_FUNCTION_TRACE(ev_disable_gpe);
>>> >>
>>> >> - if (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK)) {
>>> >> + if (gpe_event_info->flags &&
>>> >> + (!(gpe_event_info->flags &
ACPI_GPE_ENABLE_MASK))) {
>>> >> return_ACPI_STATUS(AE_OK);
>>> >> }
>>> >>
>>>
>>> Causes ACPI battery problems...
>>>
>>> https://bugzilla.redhat.com/show_bug.cgi?id=436959
>>
>>Okay, i've droppped it until 436959 can be figured out.
>>
>>thanks Chuck,
>>-Len
>>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] ACPI: disable stray gpe correctly
2008-03-14 21:48 ` Moore, Robert
@ 2008-03-17 2:09 ` Zhang, Rui
0 siblings, 0 replies; 8+ messages in thread
From: Zhang, Rui @ 2008-03-17 2:09 UTC (permalink / raw)
To: Moore, Robert, Len Brown, Chuck Ebbert; +Cc: linux-acpi, Lin, Ming M, davej
Agree. :)
I'll work on that problem.
Thanks,
rui
>-----Original Message-----
>From: Moore, Robert
>Sent: Saturday, March 15, 2008 5:49 AM
>To: Moore, Robert; Len Brown; Chuck Ebbert
>Cc: Zhang, Rui; linux-acpi; Lin, Ming M; davej@redhat.com
>Subject: RE: [PATCH] ACPI: disable stray gpe correctly
>
>I'm going to back this out until the reported problem is resolved.
>Bob
>
>
>>-----Original Message-----
>>From: Moore, Robert
>>Sent: Wednesday, March 12, 2008 2:59 PM
>>To: 'Len Brown'; Chuck Ebbert
>>Cc: Zhang, Rui; linux-acpi; Lin, Ming M; davej@redhat.com
>>Subject: RE: [PATCH] ACPI: disable stray gpe correctly
>>
>>This patch looked fairly benign to me, so I've committed it to the
ACPICA
>>core for the next release this week.
>>
>>The comment I added for the patch looks like this:
>>
>> /*
>> * Ignore this if the GPE is valid and not enabled.
>> *
>> * Flags is only zero if GPE is neither enabled or disabled -- it
may
>> * be a spurious or stray GPE -- disable it in the default case
below.
>> */
>> if (GpeEventInfo->Flags &&
>> (!(GpeEventInfo->Flags & ACPI_GPE_ENABLE_MASK)))
>> {
>> return_ACPI_STATUS (AE_OK);
>> }
>>
>>
>>If there are problems, I will back it out. Please let me know ASAP
what the
>>issue is in 436959.
>>
>>Thanks,
>>Bob
>>
>>
>>
>>>-----Original Message-----
>>>From: Len Brown [mailto:lenb@kernel.org]
>>>Sent: Wednesday, March 12, 2008 1:10 PM
>>>To: Chuck Ebbert
>>>Cc: Zhang, Rui; linux-acpi; Lin, Ming M; Moore, Robert;
davej@redhat.com
>>>Subject: Re: [PATCH] ACPI: disable stray gpe correctly
>>>
>>>
>>>> > On Sunday 09 March 2008, Zhang, Rui wrote:
>>>> >> Disable stray GPE correctly
>>>> >> https://bugzilla.redhat.com/show_bug.cgi?id=251744
>>>> >> http://bugzilla.kernel.org/show_bug.cgi?id=6217
>>>> >>
>>>> >> Sighed-off-by: Zhang Rui <rui.zhang@intel.com>
>>>> >> ---
>>>> >> drivers/acpi/events/evgpe.c | 3 ++-
>>>> >> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>> >>
>>>> >> Index: linux-2.6/drivers/acpi/events/evgpe.c
>>>> >>
===================================================================
>>>> >> --- linux-2.6.orig/drivers/acpi/events/evgpe.c
>>>> >> +++ linux-2.6/drivers/acpi/events/evgpe.c
>>>> >> @@ -248,7 +248,8 @@ acpi_status acpi_ev_disable_gpe(struct a
>>>> >>
>>>> >> ACPI_FUNCTION_TRACE(ev_disable_gpe);
>>>> >>
>>>> >> - if (!(gpe_event_info->flags & ACPI_GPE_ENABLE_MASK)) {
>>>> >> + if (gpe_event_info->flags &&
>>>> >> + (!(gpe_event_info->flags &
ACPI_GPE_ENABLE_MASK))) {
>>>> >> return_ACPI_STATUS(AE_OK);
>>>> >> }
>>>> >>
>>>>
>>>> Causes ACPI battery problems...
>>>>
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=436959
>>>
>>>Okay, i've droppped it until 436959 can be figured out.
>>>
>>>thanks Chuck,
>>>-Len
>>>
>>>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-03-17 2:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-10 2:04 [PATCH] ACPI: disable stray gpe correctly Zhang, Rui
2008-03-11 6:06 ` Len Brown
2008-03-12 19:55 ` Chuck Ebbert
2008-03-12 20:09 ` Len Brown
2008-03-12 21:59 ` Moore, Robert
2008-03-12 22:35 ` Chuck Ebbert
2008-03-14 21:48 ` Moore, Robert
2008-03-17 2:09 ` Zhang, Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox