Re: [PATCH] ACPI: disable stray gpe correctly

[Chuck Ebbert <cebbert@redhat.com>]

On 03/12/2008 05:59 PM, Moore, Robert wrote:
> This patch looked fairly benign to me, so I've committed it to the
> ACPICA core for the next release this week.
> 
> The comment I added for the patch looks like this:
> 
>     /*
>      * Ignore this if the GPE is valid and not enabled.
>      *
>      * Flags is only zero if GPE is neither enabled or disabled -- it
> may
>      * be a spurious or stray GPE -- disable it in the default case
> below.
>      */
>     if (GpeEventInfo->Flags &&
>        (!(GpeEventInfo->Flags & ACPI_GPE_ENABLE_MASK)))
>     {
>         return_ACPI_STATUS (AE_OK);
>     }
> 
> 
> If there are problems, I will back it out. Please let me know ASAP what
> the issue is in 436959.
> 

The battery information is all wrong with the patch applied.

The battery model changes from 'NBP6A24A1' to 'Main', all the capacities
are wrong, and it reports that the battery is discharging when it is fully
charged and the machine is running on AC.