Re: [PATCH 1/4] Remove path attribute from sgi_hotplug

Prarit Bhargava
2008-03-03T18:54:40Z

>> - bss_hotplug_slot->name = kmalloc(SN_SLOT_NAME_SIZE, GFP_KERNEL);
>> - if (!bss_hotplug_slot->name) {
>> - kfree(bss_hotplug_slot->private);
>> - return -ENOMEM;
>> - }
>> + bss_hotplug_slot->name = slot->physical_path;
>>
>> slot->device_num = device;
>> slot->pci_bus = pci_bus;
>> - sprintf(bss_hotplug_slot->name, "%04x:%02x:%02x",
>> - pci_domain_nr(pci_bus),
>> - ((u16)pcibus_info->pbi_buscommon.bs_persist_busnum),
>> - device + 1);
>>
>>
>
Ugh ... it has been a while since I've looked at or owned this code ;)
-- but I do seem to recall that on SGI boxes the slot's name was
different from the physical path of the device (ie, what was stamped on
the back of the PCI hotplug chassis was different from Linux' PCI name)
-- OTOH, I haven't recently looked at what slot->physical_path has been
initialized to, so they might now be one-and-the-same ....

P.