[PATCH 4/16][BUG] PCI slot: Add missing semaphore for slot release (Not for mainline!)

Kenji Kaneshige
2008-03-21T04:13:56Z

Add missing pci_bus sem into pci_destroy_slot(). There is possible
race condition because current code doesn't have any serialization
in the destroy path.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

---
drivers/pci/slot.c | 2 ++
1 file changed, 2 insertions(+)

Index: linux-2.6.25-rc6/drivers/pci/slot.c
===================================================================
--- linux-2.6.25-rc6.orig/drivers/pci/slot.c
+++ linux-2.6.25-rc6/drivers/pci/slot.c
@@ -196,7 +196,9 @@ EXPORT_SYMBOL_GPL(pci_create_slot);

int pci_destroy_slot(struct pci_slot *slot)
{
+ down_write(&pci_bus_sem);
kobject_put(&slot->kobj);
+ up_write(&pci_bus_sem);

dbg("%s: decreased refcount to %d on %x:%d\n", __func__,
slot->kobj.kref.refcount, slot->bus->number, slot->number);