Re: [PATCH 7/16][BUG] PCI slot: Remove compiler warnings (Not for mainline!)

Alex Chiang
2008-03-21T20:01:33Z

* Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>:
> Remove following compiler warnings.

Merged, thanks.

/ac

>
> drivers/pci/slot.c: In function 'pci_create_slot':
> drivers/pci/slot.c:146: warning: format '%d' expects type 'int', but argument 4 has type 'atomic_t'
> drivers/pci/slot.c: In function 'pci_destroy_slot':
> drivers/pci/slot.c:198: warning: format '%d' expects type 'int', but argument 4 has type 'atomic_t'
>
> Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
>
> ---
> drivers/pci/slot.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> Index: linux-2.6.25-rc6/drivers/pci/slot.c
> ===================================================================
> --- linux-2.6.25-rc6.orig/drivers/pci/slot.c
> +++ linux-2.6.25-rc6/drivers/pci/slot.c
> @@ -142,8 +142,8 @@ struct pci_slot *pci_create_slot(struct
> if (slot->number == slot_nr) {
> kobject_get(&slot->kobj);
> dbg("%s: bumped refcount to %d on %x:%d\n",
> - __func__, slot->kobj.kref.refcount,
> - parent->number, slot_nr);
> + __func__, atomic_read(&slot->kobj.kref.refcount),
> + parent->number, slot_nr);
> goto out;
> }
> }
> @@ -196,7 +196,8 @@ int pci_destroy_slot(struct pci_slot *sl
> up_write(&pci_bus_sem);
>
> dbg("%s: decreased refcount to %d on %x:%d\n", __func__,
> - slot->kobj.kref.refcount, slot->bus->number, slot->number);
> + atomic_read(&slot->kobj.kref.refcount), slot->bus->number,
> + slot->number);
> return 0;
> }
> EXPORT_SYMBOL_GPL(pci_destroy_slot);
>
>