From: "Baicar, Tyler" <tbaicar@codeaurora.org>
To: rjw@rjwysocki.net
Cc: Borislav Petkov <bp@alien8.de>,
lenb@kernel.org, will.deacon@arm.com, james.morse@arm.com,
bp@suse.de, shiju.jose@huawei.com, geliangtang@gmail.com,
andriy.shevchenko@linux.intel.com, tony.luck@intel.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] acpi: apei: clear error status before acknowledging the error
Date: Wed, 13 Sep 2017 08:40:43 -0600 [thread overview]
Message-ID: <47ed1861-1bdb-7caf-3d6b-5304235c7e10@codeaurora.org> (raw)
In-Reply-To: <20170829081610.moq2dtxzz4vrbmo5@pd.tnic>
On 8/29/2017 2:16 AM, Borislav Petkov wrote:
> On Mon, Aug 28, 2017 at 10:53:41AM -0600, Tyler Baicar wrote:
>> Currently we acknowledge errors before clearing the error status.
>> This could cause a new error to be populated by firmware in-between
>> the error acknowledgment and the error status clearing which would
>> cause the second error's status to be cleared without being handled.
>> So, clear the error status before acknowledging the errors.
>>
>> Also, make sure to acknowledge the error if the error status read
>> fails.
>>
>> V3: Seperate check for -ENOENT return value
>>
>> V2: Only send error ack if there was an error populated
>> Remove curly braces that are no longer needed
>>
>> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
>> ---
>> drivers/acpi/apei/ghes.c | 16 +++++++++-------
>> 1 file changed, 9 insertions(+), 7 deletions(-)
> Reviewed-by: Borislav Petkov <bp@suse.de>
Hello Rafael,
Were you able to apply this patch?
Thanks,
Tyler
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-09-13 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 16:53 [PATCH V3] acpi: apei: clear error status before acknowledging the error Tyler Baicar
2017-08-28 17:01 ` Andy Shevchenko
2017-08-28 17:14 ` Borislav Petkov
2017-08-28 17:20 ` Andy Shevchenko
2017-08-28 17:25 ` Borislav Petkov
2017-08-28 17:44 ` Andy Shevchenko
2017-08-28 18:27 ` Borislav Petkov
2017-08-28 19:12 ` Andy Shevchenko
2017-08-28 19:14 ` Andy Shevchenko
2017-08-29 8:16 ` Borislav Petkov
2017-09-13 14:40 ` Baicar, Tyler [this message]
2017-09-21 15:27 ` Tyler Baicar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ed1861-1bdb-7caf-3d6b-5304235c7e10@codeaurora.org \
--to=tbaicar@codeaurora.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=geliangtang@gmail.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shiju.jose@huawei.com \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox