Re: [PATCH 3/3] Synchronize wireless power state with hardware for Sony laptops

[Sergey Yanovich <ynvich@gmail.com>]

Sergey Yanovich wrote:
> The drivers stores own representation of wireless power states. Since
> hardware switch takes presedence over software controls, internal
> data goes out of sync with device state, after the hardware switch
> is toggled.
> 
> This patch safeguards itself against possible conflicts with earlier
> models, and will only have any effect on the latest Type 4 devices.
> ---


> @@ -1833,11 +1846,15 @@ static ssize_t sony_pic_wifipower_show(struct device *dev,
>  static void __sony_pic_set_bluetoothpower(u8 state)
>  {
>  	state = !!state;
> -	if (spic_dev.bluetooth_power == state)
> +	mutex_lock(&spic_dev.lock);

This is redundant and causing a deadlock :) Correction follows.


-- 
Sergey Yanovich