From: Randy Dunlap <randy.dunlap@oracle.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Len Brown <lenb@kernel.org>,
ibm-acpi-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 10/14] ACPI: thinkpad-acpi: use uppercase for "LED" on user documentation
Date: Fri, 25 Apr 2008 21:06:52 -0700 [thread overview]
Message-ID: <4812AA5C.3010600@oracle.com> (raw)
In-Reply-To: <1209182550-32725-11-git-send-email-hmh@hmh.eng.br>
Henrique de Moraes Holschuh wrote:
> Change all occourences of the "led" word to full uppercase in user
> documentation.
>
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>
Thank you.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> Documentation/laptops/thinkpad-acpi.txt | 22 +++++++++++-----------
> 1 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/laptops/thinkpad-acpi.txt b/Documentation/laptops/thinkpad-acpi.txt
> index 73b80a7..947b726 100644
> --- a/Documentation/laptops/thinkpad-acpi.txt
> +++ b/Documentation/laptops/thinkpad-acpi.txt
> @@ -697,7 +697,7 @@ ThinkLight control
> ------------------
>
> procfs: /proc/acpi/ibm/light
> -sysfs attributes: as per led class, for the "tpacpi::thinklight" led
> +sysfs attributes: as per LED class, for the "tpacpi::thinklight" LED
>
> procfs notes:
>
> @@ -710,11 +710,11 @@ status as "unknown". The available commands are:
>
> sysfs notes:
>
> -The ThinkLight sysfs interface is documented by the led class
> -documentation, in Documentation/leds-class.txt. The ThinkLight led name
> +The ThinkLight sysfs interface is documented by the LED class
> +documentation, in Documentation/leds-class.txt. The ThinkLight LED name
> is "tpacpi::thinklight".
>
> -Due to limitations in the sysfs led class, if the status of the thinklight
> +Due to limitations in the sysfs LED class, if the status of the thinklight
> cannot be read or if it is unknown, thinkpad-acpi will report it as "off".
> It is impossible to know if the status returned through sysfs is valid.
>
> @@ -880,7 +880,7 @@ LED control
> -----------
>
> procfs: /proc/acpi/ibm/led
> -sysfs attributes: as per led class, see below for names
> +sysfs attributes: as per LED class, see below for names
>
> Some of the LED indicators can be controlled through this feature. On
> some older ThinkPad models, it is possible to query the status of the
> @@ -891,11 +891,11 @@ procfs notes:
>
> The available commands are:
>
> - echo '<led number> on' >/proc/acpi/ibm/led
> - echo '<led number> off' >/proc/acpi/ibm/led
> - echo '<led number> blink' >/proc/acpi/ibm/led
> + echo '<LED number> on' >/proc/acpi/ibm/led
> + echo '<LED number> off' >/proc/acpi/ibm/led
> + echo '<LED number> blink' >/proc/acpi/ibm/led
>
> -The <led number> range is 0 to 7. The set of LEDs that can be
> +The <LED number> range is 0 to 7. The set of LEDs that can be
> controlled varies from model to model. Here is the common ThinkPad
> mapping:
>
> @@ -912,7 +912,7 @@ All of the above can be turned on and off and can be made to blink.
>
> sysfs notes:
>
> -The ThinkPad LED sysfs interface is described in detail by the led class
> +The ThinkPad LED sysfs interface is described in detail by the LED class
> documentation, in Documentation/leds-class.txt.
>
> The leds are named (in LED ID order, from 0 to 7):
> @@ -920,7 +920,7 @@ The leds are named (in LED ID order, from 0 to 7):
> "tpacpi::dock_active", "tpacpi::bay_active", "tpacpi::dock_batt",
> "tpacpi::unknown_led", "tpacpi::standby".
>
> -Due to limitations in the sysfs led class, if the status of the LED
> +Due to limitations in the sysfs LED class, if the status of the LED
> indicators cannot be read due to an error, thinkpad-acpi will report it as
> a brightness of zero (same as LED off).
>
--
~Randy
next prev parent reply other threads:[~2008-04-26 4:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 4:02 [GIT PATCH] thinkpad-acpi queue for the 2.6.26 merge window (v2) Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 01/14] ACPI: thinkpad-acpi: BIOS backlight mode helper (v2.1) Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 02/14] ACPI: thinkpad-acpi: warn once about weird hotkey masks Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 03/14] ACPI: thinkpad-acpi: enhance box identification output (v2) Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 04/14] ACPI: thinkpad-acpi: rate-limit CMOS/EC unsynced error messages Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 05/14] ACPI: thinkpad-acpi: fix brightness dimming control bug Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 06/14] ACPI: thinkpad-acpi: claim tpacpi as an official short handle (v1.1) Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 07/14] ACPI: thinkpad-acpi: prepare light and LED for sysfs support Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 08/14] ACPI: thinkpad-acpi: add sysfs led class support for thinklight (v3.1) Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 09/14] ACPI: thinkpad-acpi: add sysfs led class support to thinkpad leds (v3.2) Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 10/14] ACPI: thinkpad-acpi: use uppercase for "LED" on user documentation Henrique de Moraes Holschuh
2008-04-26 4:06 ` Randy Dunlap [this message]
2008-04-26 4:02 ` [PATCH 11/14] ACPI: thinkpad-acpi: fluff really minor fix Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 12/14] ACPI: thinkpad-acpi: use a private workqueue Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 13/14] ACPI: thinkpad-acpi: fix selects in Kconfig Henrique de Moraes Holschuh
2008-04-26 4:02 ` [PATCH 14/14] ACPI: thinkpad-acpi: bump up version to 0.20 Henrique de Moraes Holschuh
2008-04-29 9:08 ` [GIT PATCH] thinkpad-acpi queue for the 2.6.26 merge window (v2) Len Brown
[not found] ` <200804290508.01452.lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2008-04-29 17:31 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4812AA5C.3010600@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox