Re: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

KAMEZAWA Hiroyuki
2008-05-28T00:04:19Z

On Tue, 27 May 2008 16:20:29 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Fri, 23 May 2008 15:43:48 +0900
> Taku Izumi <izumi.taku@jp.fujitsu.com> wrote:
>
> > This patch adds DMI info to enable OSI(Linux) on PRIMEQUEST.
> > (PRIMEQUEST is ia64 machine.)
> >
> > Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
> >
> > ---
> > drivers/acpi/blacklist.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > Index: linux-2.6.25.4/drivers/acpi/blacklist.c
> > ===================================================================
> > --- linux-2.6.25.4.orig/drivers/acpi/blacklist.c
> > +++ linux-2.6.25.4/drivers/acpi/blacklist.c
> > @@ -626,6 +626,20 @@ static struct dmi_system_id acpi_osi_dmi
> > DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> > },
> > },
> > + /*
> > + * Enable OSI(Linux) on Fujitsu PRIMEQUEST
> > + *
> > + * DMI_MATCH(DMI_BIOS_VERSION, "PRIMEQUEST"),
> > + *
> > + */
> > + {
> > + .callback = dmi_enable_osi_linux,
> > + .ident = "Fujitsu PRIMEQUEST",
> > + .matches = {
> > + DMI_MATCH(DMI_BIOS_VENDOR, "FUJITSU LIMITED"),
> > + DMI_MATCH(DMI_BIOS_VERSION, "PRIMEQUEST"),
> > + },
> > + },
> > {}
> > };
>
> It is unclear (to me) what the impact of this patch is. Does it fix a
> problem which would justify including these patches in 2.6.26?
>
Ah, sorry. I think this is not 2.6.26 candidates.

Before patch.
- PrimeQuest doesn't work well without acpi_osi="Linux" boot option.
After patch
- PrimeQuest works well without boot option.

But Pavel Machek and Arjan van de Ven informed us that "Supporting OSI("Linux")
on PrimeQuest will be harmful even if it works well now. Because we cannot
guarantee compatibility of this interface in future". So, we're now discussing
the problem with our firmware team.

So, please ignore this patch for a while. We'll repost if necessary.

Thank you.

Regards.
-Kame