Re: ACPI on Compaq 6715b - BIOS from the wrong end of the planet

[Richard <tuxbox.guru@gmail.com>]

Thomas Renninger wrote:
> On Tue, 2008-04-29 at 16:36 -0700, H. Peter Anvin wrote:
>   
>> Thomas Renninger wrote:
>>     
>>>>>   
>>>>>           
>>>> Thanks a Million..
>>>> noapictimer works perfectly ... BUT  .. only on 64Bit.  acpi_pm is not 
>>>> present on 32bit as a clocksource and it defaulted to jiffies. (tsc was 
>>>> marked as imreliable)
>>>>
>>>> I am really surprised that this Sempron notebook actually had 64Bit CPU 
>>>> compatibility :D
>>>>         
>>> This one helps for my Turion.
>>> AFAIK, another Turion (very similar) does not need this, but I do not
>>> know for sure.
>>>
>>>       
>> Is the common denominator here the Turion (and if so, what model 
>> number), or is it the mainboard or BIOS?  If the latter, it should be 
>> keyed on a DMI signature instead of the CPU.
>>     
>
> noapictimer is needed on machines with C1E (when all cores issue C1, the
> BIOS may decide to shut down more things, like the apic timer...).
> Therefore the checking for C1E (in arch/x86/setup_64.c
> amd_apic_timer_broken(..)). The check for C1E is done for K8 RevF, K10
> and K11. I now expect it simply has been forgotten that K8 RevE CPUs
> may also have C1E (maybe only mobile Turion and Semprons, could the
> check below be enhanced to only check mobile CPUs?)?
>
> This patch should also check for RevE with more than one core. It's
> untested, but should compile. Does this one work for you Richard?
>
>
> Also check for broken apic timer for RevE multi core machines
>
> Signed-off-by: Thomas Renninger <trenn@suse.de>
>
> Index: linux-2.6/arch/x86/kernel/setup_64.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/setup_64.c
> +++ linux-2.6/arch/x86/kernel/setup_64.c
> @@ -686,7 +686,7 @@ static void __cpuinit early_init_amd_mc(
>  #define CPUID_XFAM_10H		0x00100000
>  #define CPUID_XFAM_11H		0x00200000
>  #define CPUID_XMOD		0x000f0000
> -#define CPUID_XMOD_REV_F	0x00040000
> +#define CPUID_XMOD_REV_E	0x00020000
>  
>  /* AMD systems with C1E don't have a working lAPIC timer. Check for that. */
>  static __cpuinit int amd_apic_timer_broken(void)
> @@ -695,7 +695,9 @@ static __cpuinit int amd_apic_timer_brok
>  
>  	switch (eax & CPUID_XFAM) {
>  	case CPUID_XFAM_K8:
> -		if ((eax & CPUID_XMOD) < CPUID_XMOD_REV_F)
> +		if ((eax & CPUID_XMOD) < CPUID_XMOD_REV_E)
> +			break;
> +		if (num_online_cpus() < 2)
>  			break;
>  	case CPUID_XFAM_10H:
>  	case CPUID_XFAM_11H:
>
>
>
>
>   


Hi there,

The results are in.. and the patch done nothing on my notebook. The 
symptoms are exactly the same as before. Kernel loads, INIT starts and 
then the machine shuts down a few seconds later. noapictimer still fixes 
it tho' 

<insert twilight zone music here>

Thanks a million,
Richard




--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html