[patch 03/54] PNPACPI: continue after _CRS and _PRS errors

Bjorn Helgaas
2008-04-25T18:39:31Z

[-- Attachment #1: pnpacpi-ignore-errors --]
[-- Type: text/plain, Size: 1233 bytes --]

Keep going and register the device even if we have trouble parsing
_CRS or _PRS. A parsing problem might mean we ignore some resources
the device is using, or we might not be able to change its resources.
But we should still take note of anything we *could* parse correctly.

Also remove reference to dev_id because I plan to remove it soon.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

Index: work10/drivers/pnp/pnpacpi/core.c
===================================================================
--- work10.orig/drivers/pnp/pnpacpi/core.c 2008-04-25 11:12:17.000000000 -0600
+++ work10/drivers/pnp/pnpacpi/core.c 2008-04-25 11:14:44.000000000 -0600
@@ -213,8 +213,7 @@
&dev->res);
if (ACPI_FAILURE(status) && (status != AE_NOT_FOUND)) {
pnp_err("PnPACPI: METHOD_NAME__CRS failure for %s",
- dev_id->id);
- goto err1;
+ acpi_device_hid(device));
}
}

@@ -223,8 +222,7 @@
dev);
if (ACPI_FAILURE(status) && (status != AE_NOT_FOUND)) {
pnp_err("PnPACPI: METHOD_NAME__PRS failure for %s",
- dev_id->id);
- goto err1;
+ acpi_device_hid(device));
}
}

@@ -252,8 +250,6 @@
num++;

return AE_OK;
-err1:
- kfree(dev_id);
err:
kfree(dev);
return -EINVAL;

--