Re: [patch 50/54] ISAPNP: fold isapnp_read_resources() back into isapnp_get_resources()

Rene Herman
2008-04-26T23:07:18Z

On 25-04-08 20:38, Bjorn Helgaas wrote:

> + for (i = 0; i < ISAPNP_MAX_MEM; i++) {
> + ret = isapnp_read_word(ISAPNP_CFG_MEM + (i << 3)) << 8;
> + if (!ret)
> + continue;
> + pnp_res = pnp_add_mem_resource(dev, ret, ret, 0);
> + if (pnp_res)
> + pnp_res->index = i;
> + }
> + for (i = 0; i < ISAPNP_MAX_IRQ; i++) {
> + ret = (isapnp_read_word(ISAPNP_CFG_IRQ + (i << 1)) >>
> + 8);

Truly trivial, but if you kill the useless outer (), it fits on one line...

Rene