From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rene Herman Subject: Re: [patch 2/4] PNP: replace pnp_resource_table with dynamically allocated resources Date: Thu, 22 May 2008 23:18:47 +0200 Message-ID: <4835E337.4050501@keyaccess.nl> References: <20080515220726.029505668@ldl.fc.hp.com> <20080515220754.684738602@ldl.fc.hp.com> <483209BF.3040208@keyaccess.nl> <200805191741.16488.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200805191741.16488.bjorn.helgaas@hp.com> Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Helgaas Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Adam Belay , Adam M Belay , Li Shaohua , Matthieu Castet , Thomas Renninger , Jaroslav Kysela , Andrew Morton , Takashi Iwai List-Id: linux-acpi@vger.kernel.org On 20-05-08 01:41, Bjorn Helgaas wrote: > On Monday 19 May 2008 05:14:07 pm Rene Herman wrote: >>> static void pnp_clean_resource_table(struct pnp_dev *dev) [ ... ] >> Do correct me if I'm wrong but I don't believe this will do. The index >> for the resources is preserved simply due to the list position after the >> DISABLED thing but here the list is reshuffled. >> >> So say I have an ISAPnP device with 2 port resources the second of which >> I force to manual setting through sysfs (ie, AUTO is cleared). This API >> would then delete the first port resource after which the second port >> resource is the first entry in the list which would make for example >> isapnp_set_resource() program it into hardware index 1, no? > > My reasoning was that all AUTO entries should be at the end of the > list, so deleting them should not change the order of other entries. Yes, so it seems. You even said that in the changelog. Missed it, sorry. Acked-by: Rene Herman I have had your v2 series running on two machines (using PnPBIOS and ISAPnP) for a few days now and I haven't seen anything wrong. Looking good therefore. Good stuff! Rene.