public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Jaeger <thjaeger@gmail.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Adam Belay <ambx1@neo.rr.com>, Adam M Belay <abelay@mit.edu>,
	Matthieu Castet <castet.matthieu@free.fr>,
	Li Shaohua <shaohua.li@intel.com>, Len Brown <lenb@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Robert Moore <Robert.Moore@intel.com>,
	linux-acpi@vger.kernel.org
Subject: Re: PNPACPI: use _CRS IRQ descriptor length for _SRS
Date: Sat, 24 May 2008 14:55:20 -0400	[thread overview]
Message-ID: <48386498.6010006@gmail.com> (raw)
In-Reply-To: <200805231629.24421.bjorn.helgaas@hp.com>

Bjorn Helgaas wrote:
> [This fixes a long-standing parport PNPACPI bug, and it would
> nice to have it in 2.6.26.]
>   
I agree, especially since the ground work has already been laid in 
1d5b285da1893b90507b081664ac27f1a8a3dc5b.
> @@ -799,11 +802,14 @@ static void pnpacpi_encode_irq(struct pn
>  		irq->sharable = ACPI_SHARED;
>  	irq->interrupt_count = 1;
>  	irq->interrupts[0] = p->start;
> +	irq->descriptor_length = resource->data.irq.descriptor_length;
>   
I don't understand the point of this line.  Aren't 
irq->descriptor_length and resource->data.irq.descriptor_length the same 
thing?

Bjorn, while we're on the subject, could you have a look at 
http://bugzilla.kernel.org/show_bug.cgi?id=9487#c32 ? I've noticed that 
you've already fixed the third point there; the other two points may 
well be irrelevant or never occur in practice, but then they could be 
the sort of thing that costs somebody hours of debugging time.

Thanks,
Tom

  reply	other threads:[~2008-05-24 18:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-23 22:29 PNPACPI: use _CRS IRQ descriptor length for _SRS Bjorn Helgaas
2008-05-24 18:55 ` Thomas Jaeger [this message]
2008-05-27 16:47   ` Bjorn Helgaas
2008-05-27 16:53 ` PNPACPI: use _CRS IRQ descriptor length for _SRS, v2 Bjorn Helgaas
2008-06-09 18:51   ` Bjorn Helgaas
2008-06-09 22:02     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48386498.6010006@gmail.com \
    --to=thjaeger@gmail.com \
    --cc=Robert.Moore@intel.com \
    --cc=abelay@mit.edu \
    --cc=akpm@linux-foundation.org \
    --cc=ambx1@neo.rr.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=castet.matthieu@free.fr \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox