From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] libata: Handle bay devices in dock stations Date: Wed, 28 May 2008 23:39:09 +0900 Message-ID: <483D6E8D.7030409@gmail.com> References: <20080528143857.GB5585@homac.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from yw-out-2324.google.com ([74.125.46.31]:61375 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbYE1Oj1 (ORCPT ); Wed, 28 May 2008 10:39:27 -0400 Received: by yw-out-2324.google.com with SMTP id 9so1979232ywe.1 for ; Wed, 28 May 2008 07:39:16 -0700 (PDT) In-Reply-To: <20080528143857.GB5585@homac.suse.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: linux-kernel@vger.kernel.org, Tejun Heo , linux-ide@vger.kernel.org, Jeff Garzik , linux-acpi@vger.kernel.org, Matthew Garrett Holger Macht wrote: > * Differentiate between bay devices in dock stations and others: > > - When an ACPI_NOTIFY_EJECT_REQUEST appears, just signal uevent to > userspace (that is when the optional eject button on a bay device is > pressed/pulled) giving the possibility to unmount file systems and to > clean up. Also, only send uevent in case we get an EJECT_REQUEST > without doing anything else. In other cases, you'll get an add/remove > event because libata attaches/detaches the device. > > - In case of a dock event, which in turn signals an > ACPI_NOTIFY_EJECT_REQUEST, immediately detach the device, because it > may already have been gone > > * In case of an ACPI_NOTIFY_DEVICE/BUS_CHECK, evaluate _STA to check if > the device has been plugged or unplugged. If plugged, hotplug it, if > unplugged, just signal event to userspace > (initial patch by Matthew Garrett ) > > * Call ACPI _EJ0 for detached devices > > Signed-off-by: Holger Macht Acked-by: Tejun Heo -- tejun