From: Rene Herman <rene.herman@keyaccess.nl>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, Adam Belay <ambx1@neo.rr.com>,
Adam M Belay <abelay@mit.edu>, Li Shaohua <shaohua.li@intel.com>,
Matthieu Castet <castet.matthieu@free.fr>,
Thomas Renninger <trenn@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Tom Jaeger <ThJaeger@gmail.com>
Subject: Re: [patch 2/2] PNPACPI: fix shareable IRQ encode/decode
Date: Wed, 28 May 2008 22:58:47 +0200 [thread overview]
Message-ID: <483DC787.6070700@keyaccess.nl> (raw)
In-Reply-To: <20080527224938.681457358@ldl.fc.hp.com>
On 28-05-08 00:49, Bjorn Helgaas wrote:
> When we encode IRQ resources, we should use the "shareable"
> flag we got from _PRS rather than guessing based on the
> IRQ trigger mode.
>
> This is based on a patch by Tom Jaeger <ThJaeger@gmail.com>:
> http://bugzilla.kernel.org/show_bug.cgi?id=9487#c32
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Not-commented-on-by: Rene Herman <rene.herman@gmail.com>
Makes sense patchwise but one would expect that it wasn't that way to
start with due to perhaps some/many/most BIOSen not encoding the flag
correctly in _PRS. Don't know ACPI though...
Rene.
next prev parent reply other threads:[~2008-05-28 20:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 22:49 [patch 0/2] PNPACPI: fix IRQ encoding problems Bjorn Helgaas
2008-05-27 22:49 ` [patch 1/2] PNPACPI: fix IRQ flag decoding Bjorn Helgaas
2008-05-28 20:53 ` Rene Herman
2008-05-27 22:49 ` [patch 2/2] PNPACPI: fix shareable IRQ encode/decode Bjorn Helgaas
2008-05-28 20:58 ` Rene Herman [this message]
2008-05-28 22:05 ` Bjorn Helgaas
2008-05-28 23:14 ` Rene Herman
2008-05-29 14:41 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483DC787.6070700@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=ThJaeger@gmail.com \
--cc=abelay@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=ambx1@neo.rr.com \
--cc=bjorn.helgaas@hp.com \
--cc=castet.matthieu@free.fr \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox