Re: [PATCH] libata: Handle bay devices in dock stations

Holger Macht
2008-06-01T16:02:28Z

On Fri 30. May - 01:40:19, Tejun Heo wrote:
> Holger Macht wrote:
> > On Thu 29. May - 15:49:34, Matthew Garrett wrote:
> >> Got it. It works if I lose the ata_port_freeze() from
> >> ata_acpi_detach_device.
> >
> > Tejun, any idea? This is in for quite some time now. Maybe there's some
> > involved...
>
> Does changing it to ata_port_schedule_eh() make any difference?

Finally found a system to reproduce the freeze...

And yes, removing ata_port_freeze() and only doing ata_port_schedule_eh()
in the case where the device has already gone works and prevents the
freeze. Also the docking case works. If this change is not only for
finding out what's going wrong, I'm going resend the patch with your
documentation additions, ok?

Regards,
Holger