Re: [PATCH] libata: Handle bay devices in dock stations

Tejun Heo
2008-06-09T04:56:28Z

Matthew Garrett wrote:
> On Mon, Jun 09, 2008 at 10:44:01AM +0900, Tejun Heo wrote:
>
>> TF-based ATA controllers are very sensitive to how the registers are
>> accessed and sometimes lock up the whole machine when they are not happy
>> by indefinitely holding the PCI bus. This could have been the case if
>> IOs were in flight when the dock event occurred. Were they?
>
> I'd stopped hal, so I can't imagine that userspace was causing any to be
> generated at that point.

Ah... okay. Stupid me. libata EH always resets a frozen port to
un-freeze it even if it's unoccupied to listen for hotplug events. So,
if dock notifies device removal after the actual device is gone && the
port is frozen as a result, libata EH will try to reset the port after
the device is gone and in this case the controller locks up the whole
machine for that. If schedule_eh is used, libata EH just removes the
device and does nothing else and the controller is happy.

This isn't too safe tho. There can be other things which can trigger
port reset. ie. hotplug request from userland, in-flight IOs at the
time of dock removal, etc... Maybe we need to implement a flag to
indicate that the port is dead and shouldn't be accessed in any way.

Thanks.

--
tejun