Re: [PATCH] libata: Handle bay devices in dock stations

Holger Macht
2008-06-03T18:23:27Z

On Tue 03. Jun - 19:13:46, Matthew Garrett wrote:
> On Tue, Jun 03, 2008 at 02:07:42PM -0400, Jeff Garzik wrote:
>
> > It would be nice if you and Holger could work together to produce a
> > single patch[set]... right now I have patches from both of you, and I
> > was sorta waiting on the thread to die down to see if competing patches
> > might merge into a single set
>
> I think we were waiting for feedback from Tejun as to why removing the
> port freeze call fixed the hang I was seeing? Beyond that, Holger's
> latest patch looked good to me.

My suspicion is just that calling ata_port_freeze() on an already frozen
port is not good ;-)

I'll resend the merged patch.

Regards,
Holger