Re: [patch 15/15] PNP: convert resource options to single linked list

Rene Herman
2008-06-04T11:48:35Z

On 04-06-08 01:52, Rene Herman wrote:

Mmm. If you care for it:

> === 4 === quirk_ad1815_mpu_resources, ADS7151
>
> These results are with the dependent cloning already removed locally.
>
> * pre-quirk:
>
> irq 5,7,2/9,11,12 High-Edge
> Dependent: 00 - Priority preferred
> port 0x330-0x330, align 0x0, size 0x2, 10-bit address decoding
> Dependent: 01 - Priority acceptable
> port 0x300-0x300, align 0x0, size 0x2, 10-bit address decoding
> Dependent: 02 - Priority functional
> port 0x100-0x3fe, align 0x1, size 0x2, 10-bit address decoding
>
> * post-quirk:
>
> irq 5,7,2/9,11,12 High-Edge
> Dependent: 00 - Priority preferred
> port 0x330-0x330, align 0x0, size 0x2, 10-bit address decoding
> Dependent: 01 - Priority acceptable
> port 0x300-0x300, align 0x0, size 0x2, 10-bit address decoding
> Dependent: 02 - Priority functional
> port 0x100-0x3fe, align 0x1, size 0x2, 10-bit address decoding
>
>
> See why that "(optional)" flag display is good? :-) I ofcourse tested
> things and the flag works great...
>
>
> == 5 == quirk_add_irq_optional_dependent_sets, ADS7181
>
> * pre-quirk:
>
> Dependent: 00 - Priority preferred
> irq 2/9 High-Edge
> port 0x330-0x330, align 0xf, size 0x2, 16-bit address decoding
> Dependent: 01 - Priority acceptable
> irq 2/9 High-Edge
> port 0x300-0x330, align 0xf, size 0x2, 16-bit address decoding
> Dependent: 02 - Priority functional
> irq 2/9,10,11 High-Edge
> port 0x300-0x330, align 0xf, size 0x2, 16-bit address decoding
>
> * post-quirk:
>
> Dependent: 00 - Priority preferred
> irq 2/9 High-Edge
> port 0x330-0x330, align 0xf, size 0x2, 16-bit address decoding
> Dependent: 01 - Priority acceptable
> irq 2/9 High-Edge
> port 0x300-0x330, align 0xf, size 0x2, 16-bit address decoding
> Dependent: 02 - Priority functional
> irq 2/9,10,11 High-Edge
> port 0x300-0x330, align 0xf, size 0x2, 16-bit address decoding
> Dependent: 03 - Priority functional
> irq 2/9 High-Edge
> port 0x330-0x330, align 0xf, size 0x2, 16-bit address decoding
> Dependent: 04 - Priority functional
> irq 2/9 High-Edge
> port 0x300-0x330, align 0xf, size 0x2, 16-bit address decoding
> Dependent: 05 - Priority functional
> irq 2/9,10,11 High-Edge
> port 0x300-0x330, align 0xf, size 0x2, 16-bit address decoding

ADS7181 in fact might as well delete the IRQ from the dependents and add
"irq 2/9,10,11 High-Edge Optinal" in front as an independent same as
ADS7151. That way, all the cloning can go.

I'll probably place that on top if you don't, but you might already want
to since it loses all that code. Only difference would be that if IRQ 9
is taken and 10 free, the new situation would grab 330/10 while the old
would've taken 300/10, but that's in fact better...

Rene.