public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <teheo@suse.de>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux acpi <linux-acpi@vger.kernel.org>,
	Len Brown <lenb@kernel.org>,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	"Accardi, Kristen C" <kristen.c.accardi@intel.com>,
	Holger Macht <hmacht@suse.de>, mjg59 <mjg59@srcf.ucam.org>,
	Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 5/8] fix hotplug race
Date: Mon, 09 Jun 2008 10:16:32 +0900	[thread overview]
Message-ID: <484C8470.1000404@suse.de> (raw)
In-Reply-To: <484C843C.5010306@gmail.com>

Tejun Heo wrote:
> Shaohua Li wrote:
>> hotplug notification handler and drivers' notification handler are all
>> running in one workqueue. Before hotplug removes an acpi device, the
>> device driver's notification handler is already be recorded to run just
>> after global notification handler. After hotplug notification handler
>> runs, acpica will notice a NULL notification handler and crash. This
>> patch runs hotplug in other workqueue and wait for all acpi notication
>> handlers finish. This is found in battery hotplug, but actually all
>> hotplug can be affected.
>>
>> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
>> Signed-off-by: Shaohua Li <shaohua.li@intel.com> 
>> ---
>>  drivers/acpi/dock.c     |   24 +++++++++++++++++++++++-
>>  drivers/acpi/osl.c      |   44 +++++++++++++++++++++++++++++++++++++++-----
>>  include/acpi/acpiosxf.h |    3 +++
>>  3 files changed, 65 insertions(+), 6 deletions(-)
> 
> I don't understand the ACPI/dock specific changes but libata-acpi
> definitely looks much prettier this way.  Holger, does everything look okay?

Aiee.. This should have been a reply to PATCH 6/8 not PATCH 5/8.  Sorry.

-- 
tejun

  reply	other threads:[~2008-06-09  1:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06  5:22 [PATCH 5/8] fix hotplug race Shaohua Li
2008-06-09  1:15 ` Tejun Heo
2008-06-09  1:16   ` Tejun Heo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-05-22  6:34 Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484C8470.1000404@suse.de \
    --to=teheo@suse.de \
    --cc=hmacht@suse.de \
    --cc=hmh@hmh.eng.br \
    --cc=jeff@garzik.org \
    --cc=kristen.c.accardi@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox