linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexey Starikovskiy <astarikovskiy@suse.de>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	hmh@hmh.eng.br, Maximilian Engelhardt <maxi@daemonizer.de>,
	linux-stable@vger.kernel.org
Subject: Re: [PATCH] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC
Date: Wed, 13 Aug 2008 11:21:10 +0100	[thread overview]
Message-ID: <48A2B596.3050401@tuffmail.co.uk> (raw)
In-Reply-To: <20080812162854.d6907c95.akpm@linux-foundation.org>

Andrew Morton wrote:
> Did this get fixed yet?
>
> I have an patch in -mm which I just restored (I had to tempdrop it
> because the acpi tree was busted for some time).  But it seems to be
> old.
>
> http://bugzilla.kernel.org/show_bug.cgi?id=10919 is marked "resolved"
> but the reporter (Maximilian) seems to think otherwise.  2.6.26.x is,
> afaik, still unfixed, as is 2.6.27-rc.
>   
That's correct.  I think this specific patch should go in 2.6.27 and
2.6.26-stable.  No objections have been raised so far.

I still need this patch to make my brightness and volume control keys
usable in 2.6.27-rc3.  (They auto-repeat fast enough to trigger the
bug).  This is true even after applying the latest patches from bug
10919 (#25 + #27).

I think the 10919 fix makes it harder to reproduce, but it definitely
still happens.  I guess this is because the polling-driven EC
transactions add 1ms delays between each byte.  The slower timings leave
a window where the buggy behaviour of my EC can make a difference.  (It
has been seen to clear the "pending event" bit after a single event is
read, despite having more events pending).

There are more serious consequences of this bug.  After a while it can
confuse the EC enough to cause lockups or reboots during boot, or after
pressing a single hotkey.  This bad state is preserved over reboots,
even into known good kernels.  Fortunately the badness clears when power
is removed for a long enough period.  For a while I was worried that
something had physically burnt out.

Thanks
Alan

  reply	other threads:[~2008-08-13 10:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-15 22:25 [PATCH] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC Alan Jenkins
2008-07-17 11:49 ` Alexey Starikovskiy
2008-07-17 12:13   ` Henrique de Moraes Holschuh
2008-07-17 12:30     ` Alexey Starikovskiy
2008-07-17 16:26       ` Henrique de Moraes Holschuh
2008-07-17 16:45         ` Alan Jenkins
2008-07-17 18:50           ` Henrique de Moraes Holschuh
2008-07-17 19:07             ` Alan Jenkins
2008-07-19 11:37               ` [PATCH 0/3] acpi: GPE fixes Alan Jenkins
2008-07-19 14:07                 ` Vegard Nossum
     [not found]               ` <4881CE72.1090401@tuffmail.co.uk>
2008-07-19 11:38                 ` [PATCH 1/3] acpi: Rip out EC_FLAGS_QUERY_PENDING (prevent race condition) Alan Jenkins
2008-07-19 16:59                   ` Alexey Starikovskiy
2008-07-19 20:41                     ` Alan Jenkins
2008-07-19 21:12                       ` Alexey Starikovskiy
2008-07-20 14:55                         ` Alan Jenkins
2008-07-19 11:39                 ` [PATCH 2/3] acpi: Avoid dropping rapid GPEs on Asus EeePC and others Alan Jenkins
2008-07-19 11:39                 ` [PATCH 3/3] acpi: remove GPE polling Alan Jenkins
2008-07-17 14:35 ` [PATCH] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC Alexey Starikovskiy
2008-07-17 16:02   ` Alan Jenkins
2008-07-17 16:45     ` Alexey Starikovskiy
2008-07-17 18:55       ` Alan Jenkins
2008-07-17 18:59         ` Alexey Starikovskiy
2008-08-12 23:28           ` Andrew Morton
2008-08-13 10:21             ` Alan Jenkins [this message]
2008-08-13 10:46               ` Andrew Morton
2008-08-13 11:45                 ` Alan Jenkins
2008-08-13 11:51                 ` Alan Jenkins
2008-08-13 13:36                   ` Maximilian Engelhardt
2008-08-13 14:39                     ` Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A2B596.3050401@tuffmail.co.uk \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=akpm@linux-foundation.org \
    --cc=astarikovskiy@suse.de \
    --cc=hmh@hmh.eng.br \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stable@vger.kernel.org \
    --cc=maxi@daemonizer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).