From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: akpm@linux-foundation.org, andi@firstfloor.org,
linux-acpi@vger.kernel.org, hmh@hmh.eng.br, maxi@daemonizer.de,
stable@kernel.org
Subject: Re: [patch 2/2] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC
Date: Thu, 21 Aug 2008 14:35:16 +0100 [thread overview]
Message-ID: <48AD6F14.9080700@tuffmail.co.uk> (raw)
In-Reply-To: <48AD5BBB.2050701@suse.de>
Alexey Starikovskiy wrote:
> Hi Andrew,
>
> As I understand, this patch is wrong according to comment #65 in bug
> #9998.
>
> Regards,
> Alex.
That's more likely to have been a problem with my other patches, ripping
out the QUERY_PENDING flag and GPE polling, with (what were to Alex)
predictably bad results.
You're right this patch needs testing on it's own. But the current code
is definitely wrong.
If the "GPE polling" workaround is triggered, and there is a series of
events > one every 0.5s, the EC buffer can overflow. All it needs is an
ACPI hotkey with fast enough autorepeat. And I bet it's not just my EC
that breaks horribly when that happens.
Thanks
Alan
next prev parent reply other threads:[~2008-08-21 13:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 23:41 [patch 2/2] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC akpm
2008-08-21 12:12 ` Alexey Starikovskiy
2008-08-21 12:22 ` Andi Kleen
2008-08-21 16:18 ` Andrew Morton
2008-08-21 13:35 ` Alan Jenkins [this message]
2008-08-21 13:55 ` Alexey Starikovskiy
2008-08-21 14:42 ` Alan Jenkins
2008-08-21 16:01 ` Alexey Starikovskiy
2008-08-22 10:50 ` Alan Jenkins
2008-08-23 11:31 ` Alan Jenkins
-- strict thread matches above, loose matches on Subject: below --
2008-09-21 18:42 Alan Jenkins
2008-09-21 19:17 ` Alexey Starikovskiy
2008-09-22 1:31 ` Zhao Yakui
2008-09-22 9:08 ` Alan Jenkins
2008-09-22 11:02 ` Alan Jenkins
2008-09-22 11:36 ` Alexey Starikovskiy
2008-09-22 11:49 ` Alexey Starikovskiy
2008-09-22 12:30 ` Alan Jenkins
2008-09-22 12:35 ` Alexey Starikovskiy
2008-09-22 13:44 ` Alan Jenkins
2008-09-22 19:36 ` Alexey Starikovskiy
2008-09-23 6:19 ` Zhao Yakui
2008-09-22 1:20 ` Zhao Yakui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AD6F14.9080700@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=astarikovskiy@suse.de \
--cc=hmh@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=maxi@daemonizer.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox