Henrique de Moraes Holschuh wrote: > On Mon, 01 Sep 2008, Zhao Yakui wrote: >> Will the above two patches hit the upstream kernel? If the above two patches hits the upstream kernel, it >> seems that the boot option of "ec_intr=" comes back again and EC can't be switched from interrupt mode to polling >> mode if EC GPE interrupt is missing. In such case maybe the battery/AC/thermal driver can't work well if the info of >> battery/AC/thermal is related with EC. Maybe there exists the regression on some laptops. > > Right now, the fact that it gives up on interrupt mode too easily IS causing > regressions on ThinkPads (like the T43 I own). Since polling mode does > work, it is just a performance regression, so you won't get many reports > about it since most people don't look for such stuff in their kernel logs. > > Some ECs trigger the interrupt/poll-mode checks just on small windows > (typically during resume -- might even be a bug somewhere in ACPICA or > Linux, and not on the EC). We should not be giving up using interrupt mode > on these so easily. Maybe retry enabling interrupt mode after some seconds > a few times (like 3 or 5)? If it is a transient problem, that will avoid > the permanent performance regression of polled mode. > How about such patch? Regards, Alex.