From: roel kluin <roel.kluin@gmail.com>
To: ak@linux.intel.com, lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH ?] ACPI: pr->id is unsigned
Date: Mon, 15 Sep 2008 21:32:20 -0400 [thread overview]
Message-ID: <48CF0CA4.3090701@gmail.com> (raw)
since pr->id is unsigned, shouldn't something like
the patch below be applied?
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index e36422a..75c0f76 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -667,7 +667,7 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device)
return 0;
}
- BUG_ON((pr->id >= nr_cpu_ids) || (pr->id < 0));
+ BUG_ON((pr->id >= nr_cpu_ids) || ((unsigned long)pr->id < 0));
/*
* Buggy BIOS check
next reply other threads:[~2008-09-15 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 1:32 roel kluin [this message]
2008-09-15 20:26 ` [PATCH ?] ACPI: pr->id is unsigned Valdis.Kletnieks
2008-09-16 8:45 ` Thomas Renninger
2008-09-17 2:48 ` roel kluin
2008-09-17 7:34 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CF0CA4.3090701@gmail.com \
--to=roel.kluin@gmail.com \
--cc=ak@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox