public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Jenkins <alan.christopher.jenkins@googlemail.com>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: linux acpi <linux-acpi@vger.kernel.org>
Subject: Re: [patch 2/2] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC
Date: Mon, 22 Sep 2008 10:08:50 +0100	[thread overview]
Message-ID: <48D760A2.3030007@tuffmail.co.uk> (raw)
In-Reply-To: <48D69DC9.5060100@suse.de>

Alexey Starikovskiy wrote:
> Hi Alan,
> That patch is old news already...
> There is a new shiny one appended to 9998/10724/11549...
> Please give it a try. It does disable GPE, but for very small duration.

Ok.  I was put off by the noise :-).

I've just tested 2.6.27-rc6 with
<http://bugzilla.kernel.org/show_bug.cgi?id=9998#c81>.  It still "drops"
some events, but now it takes longer to happen.  I have to work much
harder bashing the keys to reproduce it.


Like before, missing an event has severe consequences.  The missed event
is buffered.  When a new event occurs, only the oldest event is removed
from the buffer.  Therefore the buffer can only grow.  Eventually,
something breaks.  Events stop being delivered altogether; presumably
the buffer overflows.  I confirmed that this does still happen.

Remember that these are the consequences of a specific EC bug.  On my
EC, querying an event always clears SCI_EVT, even if there are more
events pending.  It is only re-raised when a new event fires.


I'll try reading the patch.  I may try capturing an EC debug log to show
how the event is dropped, but that will take time.

Thanks
Alan

  parent reply	other threads:[~2008-09-22  9:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-21 18:42 [patch 2/2] acpi: Avoid dropping rapid hotkey events (or other GPEs) on Asus EeePC Alan Jenkins
2008-09-21 19:17 ` Alexey Starikovskiy
2008-09-22  1:31   ` Zhao Yakui
2008-09-22  9:08   ` Alan Jenkins [this message]
2008-09-22 11:02     ` Alan Jenkins
2008-09-22 11:36       ` Alexey Starikovskiy
2008-09-22 11:49         ` Alexey Starikovskiy
2008-09-22 12:30           ` Alan Jenkins
2008-09-22 12:35             ` Alexey Starikovskiy
2008-09-22 13:44               ` Alan Jenkins
2008-09-22 19:36                 ` Alexey Starikovskiy
2008-09-23  6:19           ` Zhao Yakui
2008-09-22  1:20 ` Zhao Yakui
  -- strict thread matches above, loose matches on Subject: below --
2008-08-20 23:41 akpm
2008-08-21 12:12 ` Alexey Starikovskiy
2008-08-21 12:22   ` Andi Kleen
2008-08-21 16:18     ` Andrew Morton
2008-08-21 13:35   ` Alan Jenkins
2008-08-21 13:55     ` Alexey Starikovskiy
2008-08-21 14:42       ` Alan Jenkins
2008-08-21 16:01         ` Alexey Starikovskiy
2008-08-22 10:50           ` Alan Jenkins
2008-08-23 11:31             ` Alan Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D760A2.3030007@tuffmail.co.uk \
    --to=alan.christopher.jenkins@googlemail.com \
    --cc=astarikovskiy@suse.de \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox