Re: [PATCH] ACPI: EC: do transaction from interrupt context

Zhao Yakui
2008-09-26T05:59:31Z

On Fri, 2008-09-26 at 06:42 +0100, Sitsofe Wheeler wrote:
> Zhao Yakui wrote:
> > I think that the problem on the asus-EEEPC can't be resolved really
> > by the Alexey's patch. IMO it is only lucky.
Do you have opportunity to try whether the Asus Eee PC hotkeys on
windows are very fast?
> How lucky? It really does go from excruciatingly slow to quite fast on
> that laptop. What will happen should my luck fail? What are the odds of
> my luck failing?
>
> > In fact the main problem on Asus-EEEPC is related with the broken EC.
> > Before an EC notification event is processed, another EC notification
> > event arrives again.
> > If EC driver check whether the SCI_EVT bit is set after processing
> > one EC notification event, the problem will be resolved.
> > http://bugzilla.kernel.org/show_bug.cgi?id=11089
> > Alan Jenkins already sent a patch about how to fix the issue on the
> > Asus-EEEPC.
>
> I'll cc Alan and see what he makes of this patch.
>
> > But if the above patch is merged , maybe it will break some laptops.
>
> Fair enough but can those people with such laptops test the patch too
> and report back? Can you say in what form the breakages will take? From
> what you are saying it sounds like this patch shouldn't have had any
> affect for me but it does. What happens when they try it? What happens
> when you try it?
>