Re: [PATCH] ACPI: EC: do transaction from interrupt context

Rafael J. Wysocki
2008-09-26T12:28:14Z

On Friday, 26 of September 2008, Zhao Yakui wrote:
> On Thu, 2008-09-25 at 18:52 +0100, Sitsofe Wheeler wrote:
> > Alexey Starikovskiy wrote:
> > > It is easier and faster to do transaction directly from interrupt context
> > > rather than waking control thread.
> > > Also, cleaner GPE storm avoidance is implemented.
> Hi, Sitsofe
> I think that the problem on the asus-EEEPC can't be resolved really
> by the Alexey's patch. IMO it is only lucky.
> In fact the main problem on Asus-EEEPC is related with the broken EC.
> Before an EC notification event is processed, another EC notification
> event arrives again.
> If EC driver check whether the SCI_EVT bit is set after processing
> one EC notification event, the problem will be resolved.
> http://bugzilla.kernel.org/show_bug.cgi?id=11089
> Alan Jenkins already sent a patch about how to fix the issue on the
> Asus-EEEPC.
>
> But if the above patch is merged , maybe it will break some laptops.
> On my laptop when issuing the query command, a non-zero query event is
> returned but it can't be processed.(There is no corresponding ACPI _Qxx
> object). At the same time the SCI_EVT bit won't be cleared. In such case
> OS can't exit the function of acpi_ec_query_handler, which causes that
> the acpid kernel thread can't work well.

So does the patch break your box as a result?

Rafael