* i2c-mux ACPI parent device references in example
@ 2025-10-08 9:14 Jonas Gorski
2025-10-18 19:41 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Jonas Gorski @ 2025-10-08 9:14 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Andy Shevchenko
Hi,
I'm currently trying to wrap my head around describing devices via SSDT.
While reading Documentation/firmware-guide/acpi/i2c-muxes.rst, the
references used for the devices behind the mux confuse me a bit.
The tree from the example is:
Device (SMB1)
{
Device (MUX0)
{
Device (CH00)
{
Device (CLIA)
{
Name (_CRS, ResourceTemplate () {
I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
AddressingMode7Bit, "\\_SB.SMB1.CH00", 0x00,
ResourceConsumer,,)
}
}
}
Device (CH01)
{
Device (CLIB)
{
Name (_CRS, ResourceTemplate () {
I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
AddressingMode7Bit, "\\_SB.SMB1.CH01", 0x00,
ResourceConsumer,,)
}
}
}
}
}
Is there a ".MUX0" missing in the references, or is it correct that it is not
present?
E.g. should it be "\\_SB.SMB1.MUX0.CH00" instead of "\\_SB.SMB1.CH00"?
FWIW, the references were changed from relative to absolute in e65cb011349e
("Documentation: ACPI: Fix parent device references").
Best regards,
Jonas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: i2c-mux ACPI parent device references in example
2025-10-08 9:14 i2c-mux ACPI parent device references in example Jonas Gorski
@ 2025-10-18 19:41 ` Andy Shevchenko
2025-10-21 7:31 ` Jonas Gorski
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2025-10-18 19:41 UTC (permalink / raw)
To: Jonas Gorski; +Cc: linux-acpi, Rafael J. Wysocki
On Wed, Oct 08, 2025 at 11:14:37AM +0200, Jonas Gorski wrote:
> Hi,
>
> I'm currently trying to wrap my head around describing devices via SSDT.
>
> While reading Documentation/firmware-guide/acpi/i2c-muxes.rst, the
> references used for the devices behind the mux confuse me a bit.
>
> The tree from the example is:
>
> Device (SMB1)
> {
> Device (MUX0)
> {
> Device (CH00)
> {
> Device (CLIA)
> {
> Name (_CRS, ResourceTemplate () {
> I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
> AddressingMode7Bit, "\\_SB.SMB1.CH00", 0x00,
> ResourceConsumer,,)
> }
> }
> }
>
> Device (CH01)
> {
> Device (CLIB)
> {
> Name (_CRS, ResourceTemplate () {
> I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
> AddressingMode7Bit, "\\_SB.SMB1.CH01", 0x00,
> ResourceConsumer,,)
> }
> }
> }
> }
> }
>
>
> Is there a ".MUX0" missing in the references, or is it correct that it is not
> present?
>
> E.g. should it be "\\_SB.SMB1.MUX0.CH00" instead of "\\_SB.SMB1.CH00"?
>
> FWIW, the references were changed from relative to absolute in e65cb011349e
> ("Documentation: ACPI: Fix parent device references").
Oh, seems to me like a miss from my side. Thanks for a good catch!
Can you send a formal fix patch?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: i2c-mux ACPI parent device references in example
2025-10-18 19:41 ` Andy Shevchenko
@ 2025-10-21 7:31 ` Jonas Gorski
2025-10-23 18:59 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Jonas Gorski @ 2025-10-21 7:31 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-acpi, Rafael J. Wysocki
Hi,
On Sat, Oct 18, 2025 at 9:42 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, Oct 08, 2025 at 11:14:37AM +0200, Jonas Gorski wrote:
> > Hi,
> >
> > I'm currently trying to wrap my head around describing devices via SSDT.
> >
> > While reading Documentation/firmware-guide/acpi/i2c-muxes.rst, the
> > references used for the devices behind the mux confuse me a bit.
> >
> > The tree from the example is:
> >
> > Device (SMB1)
> > {
> > Device (MUX0)
> > {
> > Device (CH00)
> > {
> > Device (CLIA)
> > {
> > Name (_CRS, ResourceTemplate () {
> > I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
> > AddressingMode7Bit, "\\_SB.SMB1.CH00", 0x00,
> > ResourceConsumer,,)
> > }
> > }
> > }
> >
> > Device (CH01)
> > {
> > Device (CLIB)
> > {
> > Name (_CRS, ResourceTemplate () {
> > I2cSerialBus (0x50, ControllerInitiated, I2C_SPEED,
> > AddressingMode7Bit, "\\_SB.SMB1.CH01", 0x00,
> > ResourceConsumer,,)
> > }
> > }
> > }
> > }
> > }
> >
> >
> > Is there a ".MUX0" missing in the references, or is it correct that it is not
> > present?
> >
> > E.g. should it be "\\_SB.SMB1.MUX0.CH00" instead of "\\_SB.SMB1.CH00"?
> >
> > FWIW, the references were changed from relative to absolute in e65cb011349e
> > ("Documentation: ACPI: Fix parent device references").
>
> Oh, seems to me like a miss from my side. Thanks for a good catch!
> Can you send a formal fix patch?
Was my plan until my internet connection went down yesterday. Will
send it out once it's back.
Best regards,
Jonas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: i2c-mux ACPI parent device references in example
2025-10-21 7:31 ` Jonas Gorski
@ 2025-10-23 18:59 ` Andy Shevchenko
2025-10-27 19:28 ` Jonas Gorski
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2025-10-23 18:59 UTC (permalink / raw)
To: Jonas Gorski; +Cc: linux-acpi, Rafael J. Wysocki
On Tue, Oct 21, 2025 at 09:31:54AM +0200, Jonas Gorski wrote:
> On Sat, Oct 18, 2025 at 9:42 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Oct 08, 2025 at 11:14:37AM +0200, Jonas Gorski wrote:
...
> > > E.g. should it be "\\_SB.SMB1.MUX0.CH00" instead of "\\_SB.SMB1.CH00"?
> > >
> > > FWIW, the references were changed from relative to absolute in e65cb011349e
> > > ("Documentation: ACPI: Fix parent device references").
> >
> > Oh, seems to me like a miss from my side. Thanks for a good catch!
> > Can you send a formal fix patch?
>
> Was my plan until my internet connection went down yesterday. Will
> send it out once it's back.
Is it okay now? Or did I miss the patch?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: i2c-mux ACPI parent device references in example
2025-10-23 18:59 ` Andy Shevchenko
@ 2025-10-27 19:28 ` Jonas Gorski
0 siblings, 0 replies; 5+ messages in thread
From: Jonas Gorski @ 2025-10-27 19:28 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-acpi, Rafael J. Wysocki
On Thu, Oct 23, 2025 at 8:59 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Oct 21, 2025 at 09:31:54AM +0200, Jonas Gorski wrote:
> > On Sat, Oct 18, 2025 at 9:42 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Wed, Oct 08, 2025 at 11:14:37AM +0200, Jonas Gorski wrote:
>
> ...
>
> > > > E.g. should it be "\\_SB.SMB1.MUX0.CH00" instead of "\\_SB.SMB1.CH00"?
> > > >
> > > > FWIW, the references were changed from relative to absolute in e65cb011349e
> > > > ("Documentation: ACPI: Fix parent device references").
> > >
> > > Oh, seems to me like a miss from my side. Thanks for a good catch!
> > > Can you send a formal fix patch?
> >
> > Was my plan until my internet connection went down yesterday. Will
> > send it out once it's back.
>
> Is it okay now? Or did I miss the patch?
Getting it fixed took longer than expected, then other things took priority.
Patch should be now in your inbox (I hope I got the terminology right).
Best regards,
Jonas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-10-27 19:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-08 9:14 i2c-mux ACPI parent device references in example Jonas Gorski
2025-10-18 19:41 ` Andy Shevchenko
2025-10-21 7:31 ` Jonas Gorski
2025-10-23 18:59 ` Andy Shevchenko
2025-10-27 19:28 ` Jonas Gorski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).