Re: Bisection result: eeepc hotk breakage

[Alexey Starikovskiy <astarikovskiy@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

Alan Jenkins wrote:
> Alexey Starikovskiy wrote:
>> Alan Jenkins wrote:
>>> Alexey Starikovskiy wrote:
>>>> Alan Jenkins wrote:
>>>>> Alexey Starikovskiy wrote:
>>>>>> Alan Jenkins wrote:
>>>>>>> Well, that didn't work.
>>>>>> Pity...
>>>>>> Could you produce a debug log from EC?
>>>>>> Probably it's a good time to open a new bug report...
>>>>> <http://bugzilla.kernel.org/show_bug.cgi?id=11917>
>>>>> "Asus Eee PC hotkeys stop working after prolonged usage"
>>>>>
>>>>> I stuck at it, found a reliable test and bisected successfully.
>>>>> 2.6.28-rc2 is broken, but I can fix it by reverting the bad commit.
>>>>> (There were some conflicts, I fixed up the dock driver manually and
>>>>> avoided building the rest).
>>>> Alan, to make things clear -- reverting following commit makes EC work
>>>> without
>>>> a problem?
>>>>
>>>
>>> Yes, that's right.
>> Great!
>> What kernel version is that -- 32 or 64?
> 
> 32 bit, my EeePC doesn't do 64.
is the attached patch enough to fix ?


[-- Attachment #2: x.patch --]
[-- Type: text/x-diff, Size: 426 bytes --]

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index ef42316..e0f1534 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -751,6 +751,7 @@ ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval)
 		return status;
 	ec->gpe = tmp;
 	/* Use the global lock for all EC transactions? */
+	tmp = 0;
 	acpi_evaluate_integer(handle, "_GLK", NULL, &tmp);
 	ec->global_lock = tmp;
 	ec->handle = handle;