Re: Bisection result: eeepc hotk breakage

[Alan Jenkins <alan-jenkins@tuffmail.co.uk>]

Alexey Starikovskiy wrote:
> Alan Jenkins wrote:
>> Alexey Starikovskiy wrote:
>>> Alan Jenkins wrote:
>>>> Alexey Starikovskiy wrote:
>>>>> Alan Jenkins wrote:
>>>>>> Alexey Starikovskiy wrote:
>>>>>>> Alan Jenkins wrote:
>>>>>>>> Well, that didn't work.
>>>>>>> Pity...
>>>>>>> Could you produce a debug log from EC?
>>>>>>> Probably it's a good time to open a new bug report...
>>>>>> <http://bugzilla.kernel.org/show_bug.cgi?id=11917>
>>>>>> "Asus Eee PC hotkeys stop working after prolonged usage"
>>>>>>
>>>>>> I stuck at it, found a reliable test and bisected successfully.
>>>>>> 2.6.28-rc2 is broken, but I can fix it by reverting the bad commit.
>>>>>> (There were some conflicts, I fixed up the dock driver manually and
>>>>>> avoided building the rest).
>>>>> Alan, to make things clear -- reverting following commit makes EC
>>>>> work
>>>>> without
>>>>> a problem?
>>>>>
>>>>
>>>> Yes, that's right.
>>> Great!
>>> What kernel version is that -- 32 or 64?
>>
>> 32 bit, my EeePC doesn't do 64.
> is the attached patch enough to fix ?
>
Nice.  Yes, that fixes it, thanks!

I checked the commit diff for any similar potential errors.  Most of the
changes are "obviously correct".  However, there are changes in
thermal.c which look similar to the one that caused the problem in the
EC driver.

I think someone knowledgeable needs to audit the changes to the thermal
driver, in case the Thinkpads start melting again :-P.  The commit#
again: 27663c5855b10af9ec67bc7dfba001426ba21222.

Alan