Re: [Re: Linux 2.6.28-rc1] ACPI Warning (nspredef-0852)[...]

Rafael J. Wysocki
2008-10-25T17:59:29Z

On Saturday, 25 of October 2008, Robert Hancock wrote:
> Henrique de Moraes Holschuh wrote:
> > On Sat, 25 Oct 2008, Rafael J. Wysocki wrote:
> >> On Saturday, 25 of October 2008, Maciej Rutecki wrote:
> >>> During suspend to ram I have this message:
> >>>
> >>> ACPI Warning (nspredef-0852): \_WAK: Return type mismatch - found
> >>> Integer, expected Package [20080926]
> >>>
> >>> s2ram seems works OK
> >>>
> >>> dmesg, acpidump:
> >>> http://unixy.pl/maciek/download/kernel/2.6.28-rc1_wak/
> >> IMO it's yet another incarnation of
> >> http://bugzilla.kernel.org/show_bug.cgi?id=11822
> >
> > If this is an outright violation of the ACPI spec, let me know (and if
> > possible, please tell me the spec page). This is the kind of thing I expect
> > it would be a no-brainer to get Lenovo to fix with a BIOS update.
>
> I don't think this is the same issue, but in both cases it looks like
> the BIOS AML code is wrong (just judging from the output, haven't looked
> at the dump yet). _WAK is supposed to return a package of 2 DWORD
> values, a bit field of conditions that occurred during sleep, and the
> effective S-state the system actually entered (section 7.3.7 of the ACPI
> 3.0 spec). Presumably the BIOS is returning a single integer.

The underlying issue is we've never reported such BIOS bugs before and now we
do that unconditionally. IMnshO, this should only be done if ACPI debugging is
enabled.

While I can see a value in doing that always, IMO such a change should only be
made after a big announcement.

Thanks,
Rafael