From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] ACPI / AC: used pr_info instead of printk
Date: Fri, 11 Dec 2020 21:01:12 +0100 [thread overview]
Message-ID: <4928277.aiZ1hTckIi@kreacher> (raw)
In-Reply-To: <1607669412-21491-1-git-send-email-tiantao6@hisilicon.com>
On Friday, December 11, 2020 7:50:12 AM CET Tian Tao wrote:
> printk(KERNEL_INFO) is same with pr_info, so used pr_info instead of
> printk.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/acpi/ac.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 46a64e9..5e4b9c1 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -278,9 +278,9 @@ static int acpi_ac_add(struct acpi_device *device)
> goto end;
> }
>
> - printk(KERN_INFO PREFIX "%s [%s] (%s)\n",
> - acpi_device_name(device), acpi_device_bid(device),
> - ac->state ? "on-line" : "off-line");
> + pr_info(PREFIX "%s [%s] (%s)\n",
> + acpi_device_name(device), acpi_device_bid(device),
> + ac->state ? "on-line" : "off-line");
What about defining a proper pr_fmt() for this file instead of using PREFIX
here?
>
> ac->battery_nb.notifier_call = acpi_ac_battery_notify;
> register_acpi_notifier(&ac->battery_nb);
>
prev parent reply other threads:[~2020-12-11 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 6:50 [PATCH] ACPI / AC: used pr_info instead of printk Tian Tao
2020-12-11 20:01 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4928277.aiZ1hTckIi@kreacher \
--to=rjw@rjwysocki.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox