From: Alexey Starikovskiy <aystarik@gmail.com>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org,
Alexey Starikovskiy <astarikovskiy@suse.de>,
Len Brown <len.brown@intel.com>,
stable@kernel.org
Subject: Re: [PATCH 01/11] ACPI: EC: count interrupts only if called from interrupt handler.
Date: Sat, 29 Nov 2008 22:45:07 +0300 [thread overview]
Message-ID: <49319BC3.1020606@gmail.com> (raw)
In-Reply-To: <9b2b86520811291036w399fce94ib93a71d2475c6577@mail.gmail.com>
Alan Jenkins wrote:
> On 11/27/08, Len Brown <lenb@kernel.org> wrote:
>
>> From: Alexey Starikovskiy <astarikovskiy@suse.de>
>>
>> fix 2.6.28 EC interrupt storm regression
>>
>> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
>> Signed-off-by: Len Brown <len.brown@intel.com>
>> ---
>>
>
> Yay, this means my EeePC no longer reports interrupt storms.
>
>
Great!
> The patch looks obviously correct. What about -stable? -stable has
> all the previous EC fixes, so I assume it's affected by this
> regression.
>
IMHO, Rafael already marked it for stable.
> The patch solves a bug I was about to report. In storm avoidance
> mode, the polling is still not 100% robust against the flaky EC.
>
>
My current understanding is that firmware for this controller is not
written as a state machine,
and breaks if more than one timed action occurs.
I've found a contact with eeePC project manager and asked him about the
whole "interrupt storm" issue,
but did not get any reply yet...
> 1) If I hold down brightness up/down and then remove the power cable,
> the EC stops working immediately.
>
Probably, may be, you don't supposed to do it? :)
> 2) I had an odd one-off occasion with the familiar "out of sync
> hotkeys" & eventual EC death.
>
> Thanks
> Alan
>
>
>> drivers/acpi/ec.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
>> index cf41f9f..30f3ef2 100644
>> --- a/drivers/acpi/ec.c
>> +++ b/drivers/acpi/ec.c
>> @@ -219,7 +219,8 @@ static void gpe_transaction(struct acpi_ec *ec, u8
>> status)
>> goto unlock;
>> err:
>> /* false interrupt, state didn't change */
>> - ++ec->curr->irq_count;
>> + if (in_interrupt())
>> + ++ec->curr->irq_count;
>> unlock:
>> spin_unlock_irqrestore(&ec->curr_lock, flags);
>> }
>> --
>> 1.5.6.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2008-11-29 19:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 7:25 ACPI patches for 2.6.28-rc6 Len Brown
2008-11-27 7:25 ` [PATCH 01/11] ACPI: EC: count interrupts only if called from interrupt handler Len Brown
2008-11-27 7:25 ` [PATCH 02/11] ACPI: battery: Convert discharge energy rate to current properly Len Brown
2008-11-27 7:25 ` [PATCH 03/11] ACPI: scheduling in atomic via acpi_evaluate_integer () Len Brown
2008-11-27 7:25 ` [PATCH 04/11] ACPI suspend: Blacklist boxes that require us to set SCI_EN directly on resume Len Brown
2008-11-27 7:25 ` [PATCH 05/11] Revert "ACPI: don't enable control method power button as wakeup device when Fixed Power button is used" Len Brown
2008-11-27 7:25 ` [PATCH 06/11] sony-laptop: brightness regression fix Len Brown
2008-11-27 7:25 ` [PATCH 07/11] sony-laptop: printk tweak Len Brown
2008-11-27 7:25 ` [PATCH 08/11] ACPI: thinkpad-acpi: fix fan sleep/resume path Len Brown
2008-11-27 7:25 ` [PATCH 09/11] ACPICA: Allow _WAK method to return an Integer Len Brown
2008-11-27 7:25 ` [PATCH 10/11] ACPI: delete OSI(Linux) DMI dmesg spam Len Brown
2008-11-27 7:25 ` [PATCH 11/11] ACPICA: disable _BIF warning Len Brown
2008-11-29 18:36 ` [PATCH 01/11] ACPI: EC: count interrupts only if called from interrupt handler Alan Jenkins
2008-11-29 19:45 ` Alexey Starikovskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49319BC3.1020606@gmail.com \
--to=aystarik@gmail.com \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=astarikovskiy@suse.de \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox