public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: Ferenc Wagner <wferi@niif.hu>
Cc: linux-acpi@vger.kernel.org, "Rafael J.Wysocki" <rjw@sisk.pl>
Subject: Re: reverted battery current conversion fix
Date: Tue, 16 Dec 2008 11:43:07 +0300	[thread overview]
Message-ID: <49476A1B.7020107@suse.de> (raw)
In-Reply-To: <87zlixxaht.fsf@szonett.ki.iif.hu>

Ferenc Wagner wrote:
> Hi Alex,
> 
> I sadly noticed that your fix 558073dd was overridden by aaad0776 and
> later reverted altogether by f10a3a32.  I haven't found any discussion
> of the latter two patches, but I agree that Rafael's fix was wrong, as
> it converted the current into A instead of uA, since voltage_now is in
> mV and current_now is in mW on the new code path, and mW/mV=A.  I
> skimmed the code, but didn't find a place where the kernel provided
> time estimates, so the wild values Rafael experienced probably came
> from some application, which previously worked around the wrong sysfs
> current value (supposedly correctly interpreting it as power) and thus
> got broken by the fix.  But all of this is guesswork, I'm hunting for
> hard data.  Until I get around compiling and testing a new kernel with
> /proc/acpi, can you provide some insight?  I'm not subscribed to the
> relevant MLs, so maybe just didn't find all the pieces in the archives.
Yes, the application is kpowersaved and it is written with the assumption
that it could get remaining time by dividing either energy_now or charge_now 
by current_now.

Regards,
Alex.

       reply	other threads:[~2008-12-16  8:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87zlixxaht.fsf@szonett.ki.iif.hu>
2008-12-16  8:43 ` Alexey Starikovskiy [this message]
2008-12-16 10:40   ` reverted battery current conversion fix Ferenc Wagner
2008-12-16 10:47     ` Alexey Starikovskiy
2008-12-16 11:39       ` Ferenc Wagner
2008-12-16 14:28         ` Henrique de Moraes Holschuh
2008-12-16 15:06           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49476A1B.7020107@suse.de \
    --to=astarikovskiy@suse.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=wferi@niif.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox