From: Larry Finger <Larry.Finger@lwfinger.net>
To: Frans Pop <elendil@planet.nl>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
linux-acpi@vger.kernel.org
Subject: Re: [regression] hp-wmi: hangs system on boot
Date: Fri, 16 Jan 2009 18:52:40 -0600 [thread overview]
Message-ID: <49712BD8.6060603@lwfinger.net> (raw)
In-Reply-To: <200901170131.22541.elendil@planet.nl>
Frans Pop wrote:
> On Saturday 17 January 2009, Frans Pop wrote:
>> When I first booted .29-rc2 my HP 2510p notebook hung while loading
>> hp-wmi, which I have listed in /etc/modules. Hard poweroff was needed.
>
> Reverting the following commit fixes the problems:
>
> commit fe8e4e039dc3680681bf51af097af391f87038f8
> Author: Larry Finger <Larry.Finger@lwfinger.net>
> Date: Fri Jan 9 16:40:54 2009 -0800
>
> hp-wmi: handle rfkill_register() failure
Ooops. There was a missing if statement. This one should fix it.
Index: linux-2.6/drivers/platform/x86/hp-wmi.c
===================================================================
--- linux-2.6.orig/drivers/platform/x86/hp-wmi.c
+++ linux-2.6/drivers/platform/x86/hp-wmi.c
@@ -441,6 +441,7 @@ static int __init hp_wmi_bios_setup(stru
bluetooth_rfkill->toggle_radio = hp_wmi_bluetooth_set;
bluetooth_rfkill->user_claim_unsupported = 1;
err = rfkill_register(bluetooth_rfkill);
+ if (err)
goto register_bluetooth_error;
}
-------
next prev parent reply other threads:[~2009-01-17 0:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 23:13 [regression] hp-wmi: hangs system on boot Frans Pop
2009-01-17 0:31 ` Frans Pop
2009-01-17 0:52 ` Larry Finger [this message]
2009-01-17 0:55 ` [PATCH] hp-wmi: fix regressions caused by missing if statement Frans Pop
2009-01-17 0:57 ` Larry Finger
2009-01-17 1:48 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49712BD8.6060603@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=elendil@planet.nl \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox