* [PATCH] ACPI: Fix crash on ASUS laptops
@ 2009-01-17 11:06 Tero Roponen
2009-01-17 17:20 ` Alexey Starikovskiy
0 siblings, 1 reply; 3+ messages in thread
From: Tero Roponen @ 2009-01-17 11:06 UTC (permalink / raw)
To: linux-acpi; +Cc: astarikovskiy, len.brown
This patch fixes the crash I experienced in 2.6.29-rc2.
Tested on ASUS M50vm.
Signed-off-by: Tero Roponen <tero.roponen@gmail.com>
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index a2b82c9..5c2f5d3 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -982,7 +982,7 @@ int __init acpi_ec_ecdt_probe(void)
saved_ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
if (!saved_ec)
return -ENOMEM;
- memcpy(&saved_ec, boot_ec, sizeof(saved_ec));
+ memcpy(saved_ec, boot_ec, sizeof(*saved_ec));
/* fall through */
}
/* This workaround is needed only on some broken machines,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: Fix crash on ASUS laptops
2009-01-17 11:06 [PATCH] ACPI: Fix crash on ASUS laptops Tero Roponen
@ 2009-01-17 17:20 ` Alexey Starikovskiy
2009-01-18 1:17 ` Len Brown
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Starikovskiy @ 2009-01-17 17:20 UTC (permalink / raw)
To: Tero Roponen; +Cc: linux-acpi, len.brown
Thanks, ACK
Alex.
Tero Roponen wrote:
> This patch fixes the crash I experienced in 2.6.29-rc2.
> Tested on ASUS M50vm.
>
> Signed-off-by: Tero Roponen <tero.roponen@gmail.com>
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index a2b82c9..5c2f5d3 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -982,7 +982,7 @@ int __init acpi_ec_ecdt_probe(void)
> saved_ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
> if (!saved_ec)
> return -ENOMEM;
> - memcpy(&saved_ec, boot_ec, sizeof(saved_ec));
> + memcpy(saved_ec, boot_ec, sizeof(*saved_ec));
> /* fall through */
> }
> /* This workaround is needed only on some broken machines,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: Fix crash on ASUS laptops
2009-01-17 17:20 ` Alexey Starikovskiy
@ 2009-01-18 1:17 ` Len Brown
0 siblings, 0 replies; 3+ messages in thread
From: Len Brown @ 2009-01-18 1:17 UTC (permalink / raw)
To: Alexey Starikovskiy; +Cc: Tero Roponen, linux-acpi, len.brown
applied.
thanks,
--
Len Brown, Intel Open Source Technology Center
On Sat, 17 Jan 2009, Alexey Starikovskiy wrote:
> Thanks, ACK
> Alex.
> Tero Roponen wrote:
> > This patch fixes the crash I experienced in 2.6.29-rc2.
> > Tested on ASUS M50vm.
> >
> > Signed-off-by: Tero Roponen <tero.roponen@gmail.com>
> >
> > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> > index a2b82c9..5c2f5d3 100644
> > --- a/drivers/acpi/ec.c
> > +++ b/drivers/acpi/ec.c
> > @@ -982,7 +982,7 @@ int __init acpi_ec_ecdt_probe(void)
> > saved_ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
> > if (!saved_ec)
> > return -ENOMEM;
> > - memcpy(&saved_ec, boot_ec, sizeof(saved_ec));
> > + memcpy(saved_ec, boot_ec, sizeof(*saved_ec));
> > /* fall through */
> > }
> > /* This workaround is needed only on some broken machines,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-18 1:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-17 11:06 [PATCH] ACPI: Fix crash on ASUS laptops Tero Roponen
2009-01-17 17:20 ` Alexey Starikovskiy
2009-01-18 1:17 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox