ACPI related kernel panic when booting 2.6.29-rc2

ACPI related kernel panic when booting 2.6.29-rc2

[Peter Klotz]

On bootup of 2.6.29-rc2 a kernel panic in acpi_ns_get_parent_node occurs.

This is the backtrace (written down from the screen, maybe incomplete):

acpi_ev_execute_reg_methods
acpi_install_address_space_handler
acpi_ec_space_handler
acpi_init
ec_install_handlers
acpi_ec_ecdt_probe
acpi_init
fbmem_init
_stext
register_irq_proc
proc_pident_readdir
kernel_init
child_rip
kernel_init
child_rip

RIP [...] acpi_ns_get_parent_node

I can provide a screenshot (270kB) if this information is insufficient.

The system booted with 2.6.29-rc1 so a recent change must be the cause 
of this panic.

The system is an Asus B50A laptop running an x86_64 kernel.

Maybe this problem is related to these messages I was seeing in bootups 
of previous kernels:

[    0.176398] ACPI Error (nsaccess-0434): ACPI path has too many parent 
prefixes (^) - reached beyond root node [20080926]

Regards, Peter.

Re: ACPI related kernel panic when booting 2.6.29-rc2

[Alexey Starikovskiy]

please use the patch from Tero Roponen.

This patch fixes the crash I experienced in 2.6.29-rc2.
Tested on ASUS M50vm.

Signed-off-by: Tero Roponen <tero.roponen@gmail.com>

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index a2b82c9..5c2f5d3 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -982,7 +982,7 @@ int __init acpi_ec_ecdt_probe(void)
 		saved_ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
 		if (!saved_ec)
 			return -ENOMEM;
-		memcpy(&saved_ec, boot_ec, sizeof(saved_ec));
+		memcpy(saved_ec, boot_ec, sizeof(*saved_ec));
 	/* fall through */
 	}
 	/* This workaround is needed only on some broken machines,


sorry for screw up...
Alex

Peter Klotz wrote:
> On bootup of 2.6.29-rc2 a kernel panic in acpi_ns_get_parent_node occurs.
>
> This is the backtrace (written down from the screen, maybe incomplete):
>
> acpi_ev_execute_reg_methods
> acpi_install_address_space_handler
> acpi_ec_space_handler
> acpi_init
> ec_install_handlers
> acpi_ec_ecdt_probe
> acpi_init
> fbmem_init
> _stext
> register_irq_proc
> proc_pident_readdir
> kernel_init
> child_rip
> kernel_init
> child_rip
>
> RIP [...] acpi_ns_get_parent_node
>
> I can provide a screenshot (270kB) if this information is insufficient.
>
> The system booted with 2.6.29-rc1 so a recent change must be the cause 
> of this panic.
>
> The system is an Asus B50A laptop running an x86_64 kernel.
>
> Maybe this problem is related to these messages I was seeing in 
> bootups of previous kernels:
>
> [    0.176398] ACPI Error (nsaccess-0434): ACPI path has too many 
> parent prefixes (^) - reached beyond root node [20080926]
>
> Regards, Peter.
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ACPI related kernel panic when booting 2.6.29-rc2

[Peter Klotz]

Alexey Starikovskiy wrote:
> please use the patch from Tero Roponen.
> 
> This patch fixes the crash I experienced in 2.6.29-rc2.
> Tested on ASUS M50vm.
> 
> Signed-off-by: Tero Roponen <tero.roponen@gmail.com>
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index a2b82c9..5c2f5d3 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -982,7 +982,7 @@ int __init acpi_ec_ecdt_probe(void)
>         saved_ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
>         if (!saved_ec)
>             return -ENOMEM;
> -        memcpy(&saved_ec, boot_ec, sizeof(saved_ec));
> +        memcpy(saved_ec, boot_ec, sizeof(*saved_ec));
>     /* fall through */
>     }
>     /* This workaround is needed only on some broken machines,

Thanks a lot, this patch fixed the problem on my Asus B50A.

Regards, Peter.