From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenji Kaneshige Subject: Re: ACPI hotplug panic with current git head Date: Mon, 26 Jan 2009 11:11:35 +0900 Message-ID: <497D1BD7.9000609@jp.fujitsu.com> References: <1231604250.3642.33.camel@localhost.localdomain> <1231807693.27151.21.camel@localhost.localdomain> <1232046108.5966.57.camel@localhost.localdomain> <1232049269.5966.64.camel@localhost.localdomain> <1232050347.5966.66.camel@localhost.localdomain> <4970242C.4010404@jp.fujitsu.com> <1232115546.3224.5.camel@localhost.localdomain> <4973D2EE.3060203@jp.fujitsu.com> <1232328216.3247.68.camel@localhost.localdomain> <4973EF64.2050404@jp.fujitsu.com> <1232558780.736.24.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1232558780.736.24.camel@localhost.localdomain> Sender: linux-pci-owner@vger.kernel.org To: James Bottomley Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel , linux-pci@vger.kernel.org, "Barnes, Jesse" , shaohua.li@intel.com List-Id: linux-acpi@vger.kernel.org James Bottomley wrote: > On Mon, 2009-01-19 at 12:11 +0900, Kenji Kaneshige wrote: >> I'm sending the debug patch against 2.6.29-rc1 below. I'm also >> sending it as an attachment. It also contains the code to prevent >> the kernel panic from you. Please note that you will see two >> WARN_ON(1) messages with the patch. Those are shown by my debug >> patch. >> >> Could you try it and send me the whole dmsg output? > > Actually, the machine is now running -rc2, so the patch doesn't quite > apply: > > jejb@sparkweed> patch -p1 < ~/tmp.diff > patching file include/linux/pci-acpi.h > patching file drivers/pci/hotplug/acpiphp_glue.c > Hunk #1 FAILED at 266. > Hunk #2 succeeded at 467 (offset 2 lines). > Hunk #3 succeeded at 489 (offset 2 lines). > Hunk #4 succeeded at 518 (offset 2 lines). > Hunk #5 succeeded at 556 (offset 2 lines). > > Looks like the rejection is in the NULL check piece, so I've already > actually sent you the information it would produce. > > The dmesg output is pretty big, below. > Thank you very much, James. Thanks to you, I found the root cause of the problem. The acpi_pci_get_bridge_handle() function assumes pci_bus->self is NULL on the root bus. But it is not true and pci_bus->self can have a non-NULL value on some platfroms (like yours). So it must check pci_bus->parent instead. I found some other code that has the same wrong assumption. I'll make a fix for them and send it soon. Thanks, Kenji Kaneshige