Re: [PATCH 1/2] PCI/ACPI: move _OSC code to pci_root.c

Kenji Kaneshige
2009-02-09T05:20:01Z

Moore, Robert wrote:
> I guess this means that Linux does not currently use this interface.
>
> I think I remember that Linux implements a utility module with an interface something like "acpi_evaluate_integer", and a couple more. Perhaps acpi_evaluate_buffer already exists, you could use that.
>

Thank you for suggestion.

Unfortunately, I could not find acpi_evaluate_buffer() and something
like this. So I'd like to leave the code as it is, and wait for
acpi_evaluate_object_typed().

Thanks,
Kenji Kaneshige

>
>> -----Original Message-----
>> From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-
>> owner@vger.kernel.org] On Behalf Of Kenji Kaneshige
>> Sent: Thursday, February 05, 2009 9:43 PM
>> To: Moore, Robert
>> Cc: Alex Chiang; Jesse Barnes; linux-pci@vger.kernel.org; linux acpi;
>> Andrew Patterson
>> Subject: Re: [PATCH 1/2] PCI/ACPI: move _OSC code to pci_root.c
>>
>> Moore, Robert wrote:
>>> The acpi_evaluate_object_typed interface automatically handles the two
>> error cases you check for:
>>> 1) Checks for the case where no object is returned
>>> 2) Checks for the correct return object type (buffer in this case)
>>>
>>> Use of this interface would simplify and shrink the code.
>>>
>> Sounds good to me, but I have a question.
>>
>> The acpi_evaluate_object_typed() function seems to be compiled
>> only when ACPI_FUTURE_USAGE is defined. And it seems that there
>> is no prototype declaration. I don't know about ACPI_FUTURE_USAGE
>> at all. Could you please tell me what I should do to use
>> acpi_evaluate_object_typed()?
>>
>> Thanks,
>> Kenji Kaneshige
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>