From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: ACPI: S4 disappeared [mmotm 2009-02-10-16-35] Date: Wed, 11 Feb 2009 11:17:03 +0100 Message-ID: <4992A59F.5090502@gmail.com> References: <200902110036.n1B0aBZs013975@imap1.linux-foundation.org> <499291A3.9070501@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f20.google.com ([209.85.220.20]:63908 "EHLO mail-fx0-f20.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754661AbZBKKRM (ORCPT ); Wed, 11 Feb 2009 05:17:12 -0500 In-Reply-To: <499291A3.9070501@gmail.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jiri Slaby Cc: linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org, Linux-pm mailing list , "Rafael J. Wysocki" , Pavel Machek On 02/11/2009 09:51 AM, Jiri Slaby wrote: > On 02/11/2009 01:36 AM, akpm@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2009-02-10-16-35 has been uploaded > > Hi, > > I've found out, that S4 disappeared in this release, in comparison to mmotm > based on 2.6.29-rc2: > -ACPI: (supports S0 S1 S3 S4 S5) > +ACPI: (supports S0 S1 S3 S5) > > Any ideas what could have caused this? I think this one ARCH_HIBERNATION_POSSIBLE=n because SMP=y since config ARCH_HIBERNATION_POSSIBLE def_bool y - depends on !SMP || !X86_VOYAGER + depends on !SMP The condition was wrong, ok, anyway it worked. Would depends on !SMP || EXPERIMENTAL make sense? The smp is handled in disable_nonboot_cpus manner, right?