From mboxrd@z Thu Jan 1 00:00:00 1970 From: Witold Szczeponik Subject: Re: [PATCH] PNPACPI: Enable PNPACPI _PSx Support, v3 Date: Tue, 31 Mar 2009 22:37:23 +0200 Message-ID: <49D27F03.2070302@gmx.net> References: <49D101DA.50201@gmx.net> <1238463939.3625.99.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.gmx.net ([213.165.64.20]:45364 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751366AbZCaUhd (ORCPT ); Tue, 31 Mar 2009 16:37:33 -0400 In-Reply-To: <1238463939.3625.99.camel@localhost.localdomain> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: yakui_zhao Cc: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bjorn.helgaas@hp.com" , "abelay@mit.edu" , "rjw@sisk.pl" yakui_zhao wrote: > Very good patch. > Do you have the hardware on which the dedicated power source is > required by the serial port(PnP device) in your hand? > Yes, I have an IBM ThinkPad 600E. I need this patch in order to be able receive accurate time using a DCF77 receiver attached to the serial port. [snip] >> - if (ACPI_FAILURE(status)) >> + if (ACPI_FAILURE(acpi_set_current_resources(handle, &buffer))) >> ret = -EINVAL; >> + else if (acpi_bus_power_manageable(handle)) >> + ret = acpi_bus_set_power(handle, ACPI_STATE_D0); > How about changing the power state before calling _SRS object? I recall reading something in the ACPI spec that says that the power needs to be set after the device was enabled. But the main driver for this order (_SRS followed by _PS0) is the symmetry to the required _PS3 followed by _DIS (according to the spec). [snip] --- Witold