From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arjan van de Ven Subject: Re: [linux-pm] [2.6.30-rc1-git2 regressions] Hibernation broken and (minor but annoying) audio problem Date: Sat, 11 Apr 2009 13:11:56 -0700 Message-ID: <49E0F98C.1090202@linux.intel.com> References: <200904100057.43827.rjw@sisk.pl> <200904101439.43480.rjw@sisk.pl> <49E0EC87.9080808@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga07.intel.com ([143.182.124.22]:24207 "EHLO azsmga101.ch.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755067AbZDKUMA (ORCPT ); Sat, 11 Apr 2009 16:12:00 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Linus Torvalds Cc: Len Brown , "Rafael J. Wysocki" , Takashi Iwai , pm list , LKML , Andrew Morton , linux-acpi@vger.kernel.org, Heinz Diehl , Arkadiusz Miskiewicz , Vegard Nossum Linus Torvalds wrote: > > On Sat, 11 Apr 2009, Arjan van de Ven wrote: >> Now that I've been able to scan most of my mail; it looks like the one-liner >> should just go in. > > Ok, I committed my one-liner, and then also reverted the ACPI battery > workaround of removing __init, since the one-liner should fix that too. > > Cc'ing the people involved with that commit, just so that they know to > test to make sure the alternate fix really did fix it for them (I'm pretty > sure it does, but still a good idea to verify or at least let people know > that a previous fix got reverted) longer term I would like to work on two things 1) Fix the __init thing by just only freeing when appropriate, but not having to wait for it 2) Find a way for userland to trigger a sync - for all storage probing - for just async work - "global sync", which includes all driver init We can then have insmod/modprobe use this always, unless a flag is set (so say, udev, can load a slew of modules, and then sync only on the last one) and then after a year or two we can maybe remove the sync from the module loader ;(