From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [patch 1/8] x86: oqo: depends on INPUT_POLLDEV Date: Tue, 14 Apr 2009 10:25:20 -0700 Message-ID: <49E4C700.6010309@oracle.com> References: <200903041955.n24JtOKb027987@imap1.linux-foundation.org> <200904131916.40428.dmitry.torokhov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from acsinet12.oracle.com ([141.146.126.234]:18032 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753840AbZDNR1F (ORCPT ); Tue, 14 Apr 2009 13:27:05 -0400 In-Reply-To: <200904131916.40428.dmitry.torokhov@gmail.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Dmitry Torokhov Cc: akpm@linux-foundation.org, lenb@kernel.org, linux-acpi@vger.kernel.org, hpa@zytor.com, mingo@elte.hu, mjg59@srcf.ucam.org, tglx@linutronix.de Dmitry Torokhov wrote: > On Wednesday 04 March 2009 11:55:24 akpm@linux-foundation.org wrote: >> From: Randy Dunlap >> >> oqo driver uses polled input functions, so make it depend >> on INPUT_POLLDEV. >> >> ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] >> undefined! ERROR: "input_allocate_polled_device" >> [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR: >> "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined! >> ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] >> undefined! >> >> Signed-off-by: Randy Dunlap >> Cc: Matthew Garrett >> Cc: Ingo Molnar >> Cc: Thomas Gleixner >> Cc: "H. Peter Anvin" >> Cc: Len Brown >> Signed-off-by: Andrew Morton >> --- >> >> drivers/platform/x86/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev >> drivers/platform/x86/Kconfig --- >> a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++ >> a/drivers/platform/x86/Kconfig >> @@ -137,7 +137,7 @@ config MSI_LAPTOP >> config OQO_WMI >> tristate "OQO WMI extras" >> depends on ACPI_WMI >> - depends on INPUT >> + depends on INPUT && INPUT_POLLDEV > > Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users > should not have to select it for some drivers to become available. Did the OQO_WMI stuff go away? I can't seem to find it anywhere. -- ~Randy