[patch 1/8] x86: oqo: depends on INPUT_POLLDEV

[patch 1/8] x86: oqo: depends on INPUT_POLLDEV

[akpm]

From: Randy Dunlap <randy.dunlap@oracle.com>

oqo driver uses polled input functions, so make it depend
on INPUT_POLLDEV.

ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_allocate_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/platform/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev drivers/platform/x86/Kconfig
--- a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev
+++ a/drivers/platform/x86/Kconfig
@@ -137,7 +137,7 @@ config MSI_LAPTOP
 config OQO_WMI
        tristate "OQO WMI extras"
        depends on ACPI_WMI
-       depends on INPUT
+       depends on INPUT && INPUT_POLLDEV
        depends on RFKILL
        depends on BACKLIGHT_CLASS_DEVICE
        help
_

Re: [patch 1/8] x86: oqo: depends on INPUT_POLLDEV

[Len Brown]

applied to oqo-wmi-EXPECT-REFRESH branch

expecting a revised patch from Matthew at some point...

thanks
--
Len Brown, Intel Open Source Technology Center

On Wed, 4 Mar 2009, akpm@linux-foundation.org wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> oqo driver uses polled input functions, so make it depend
> on INPUT_POLLDEV.
> 
> ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
> ERROR: "input_allocate_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
> ERROR: "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
> ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/platform/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev drivers/platform/x86/Kconfig
> --- a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev
> +++ a/drivers/platform/x86/Kconfig
> @@ -137,7 +137,7 @@ config MSI_LAPTOP
>  config OQO_WMI
>         tristate "OQO WMI extras"
>         depends on ACPI_WMI
> -       depends on INPUT
> +       depends on INPUT && INPUT_POLLDEV
>         depends on RFKILL
>         depends on BACKLIGHT_CLASS_DEVICE
>         help
> _
> 

Re: [patch 1/8] x86: oqo: depends on INPUT_POLLDEV

[Dmitry Torokhov]

On Wednesday 04 March 2009 11:55:24 akpm@linux-foundation.org wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> oqo driver uses polled input functions, so make it depend
> on INPUT_POLLDEV.
>
> ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko]
> undefined! ERROR: "input_allocate_polled_device"
> [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR:
> "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
> ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko]
> undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>  drivers/platform/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev
> drivers/platform/x86/Kconfig ---
> a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++
> a/drivers/platform/x86/Kconfig
> @@ -137,7 +137,7 @@ config MSI_LAPTOP
>  config OQO_WMI
>         tristate "OQO WMI extras"
>         depends on ACPI_WMI
> -       depends on INPUT
> +       depends on INPUT && INPUT_POLLDEV

Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users
should not have to select it for some drivers to become available.

-- 
Dmitry

Re: [patch 1/8] x86: oqo: depends on INPUT_POLLDEV

[Randy Dunlap]

Dmitry Torokhov wrote:
> On Wednesday 04 March 2009 11:55:24 akpm@linux-foundation.org wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> oqo driver uses polled input functions, so make it depend
>> on INPUT_POLLDEV.
>>
>> ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko]
>> undefined! ERROR: "input_allocate_polled_device"
>> [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR:
>> "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
>> ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko]
>> undefined!
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
>> Cc: Ingo Molnar <mingo@elte.hu>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: "H. Peter Anvin" <hpa@zytor.com>
>> Cc: Len Brown <lenb@kernel.org>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>> ---
>>
>>  drivers/platform/x86/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev
>> drivers/platform/x86/Kconfig ---
>> a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++
>> a/drivers/platform/x86/Kconfig
>> @@ -137,7 +137,7 @@ config MSI_LAPTOP
>>  config OQO_WMI
>>         tristate "OQO WMI extras"
>>         depends on ACPI_WMI
>> -       depends on INPUT
>> +       depends on INPUT && INPUT_POLLDEV
> 
> Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users
> should not have to select it for some drivers to become available.


Did the OQO_WMI stuff go away?  I can't seem to find it anywhere.


-- 
~Randy

Re: [patch 1/8] x86: oqo: depends on INPUT_POLLDEV

[Len Brown]

> >>
> >>  drivers/platform/x86/Kconfig |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev
> >> drivers/platform/x86/Kconfig ---
> >> a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++
> >> a/drivers/platform/x86/Kconfig
> >> @@ -137,7 +137,7 @@ config MSI_LAPTOP
> >>  config OQO_WMI
> >>         tristate "OQO WMI extras"
> >>         depends on ACPI_WMI
> >> -       depends on INPUT
> >> +       depends on INPUT && INPUT_POLLDEV
> > 
> > Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users
> > should not have to select it for some drivers to become available.
> 
> 
> Did the OQO_WMI stuff go away?  I can't seem to find it anywhere.

yeah, i droppped it from my test tree while distracted with the 2.6.30
merge.  it is back now.

-Len Brown, Intel Open Source Technology Center

x86 platform: oqo: select INPUT_POLLDEV

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

OQO_WMI uses INPUT_POLLDEV, but it can select that instead of
depending on it, since it represents library code.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Len Brown <lenb@kernel.org>
---
 drivers/platform/x86/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20090519.orig/drivers/platform/x86/Kconfig
+++ linux-next-20090519/drivers/platform/x86/Kconfig
@@ -146,9 +146,10 @@ config MSI_LAPTOP
 config OQO_WMI
        tristate "OQO WMI extras"
        depends on ACPI_WMI
-       depends on INPUT && INPUT_POLLDEV
+       depends on INPUT
        depends on RFKILL
        depends on BACKLIGHT_CLASS_DEVICE
+	select INPUT_POLLDEV
        help
          Say Y here if you want to support rfkill and backlight control on
          series 2 OQO handheld devices.


-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

Re: x86 platform: oqo: select INPUT_POLLDEV

[Dmitry Torokhov]

On Tue, May 19, 2009 at 06:22:10PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> OQO_WMI uses INPUT_POLLDEV, but it can select that instead of
> depending on it, since it represents library code.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Len Brown <lenb@kernel.org>

Thanks Randy.

Acked-by: Dmitry Torokhov <dtor@mail.ru>

-- 
Dmitry

Re: x86 platform: oqo: select INPUT_POLLDEV

[Len Brown]

applied to oqo-wmi-EXPECT-REFRESH branch in acpi test tree.

mjg -- shall I send you the stuff collected on that branch
branch so that you can refresh it for 2.6.31?


thanks,
Len Brown, Intel Open Source Technology Center

Re: x86 platform: oqo: select INPUT_POLLDEV

[Matthew Garrett]

On Wed, May 27, 2009 at 04:34:35PM -0400, Len Brown wrote:
> applied to oqo-wmi-EXPECT-REFRESH branch in acpi test tree.
> 
> mjg -- shall I send you the stuff collected on that branch
> branch so that you can refresh it for 2.6.31?

Is it public? I can pull it myself easily enough.
-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: x86 platform: oqo: select INPUT_POLLDEV

[Len Brown]

> Is it public? I can pull it myself easily enough.

yes, commit id's below.

thanks,
Len Brown, Intel Open Source Technology Center


commit 261a37014c353eb392334f31f6bc2166253d12c2
Author: Randy Dunlap <randy.dunlap@oracle.com>
Date:   Tue May 26 23:59:27 2009 -0700

    oqo: select INPUT_POLLDEV
    From: Randy Dunlap <randy.dunlap@oracle.com>
    
    OQO_WMI uses INPUT_POLLDEV, but it can select that instead of 
depending on
    it, since it represents library code.
    
    Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
    Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Len Brown <len.brown@intel.com>

commit 0eba5e81e02f5f239e3691c9e9f9afef3050b387
Author: Randy Dunlap <randy.dunlap@oracle.com>
Date:   Wed Mar 4 11:55:24 2009 -0800

    x86: oqo: depends on INPUT_POLLDEV
    
    oqo driver uses polled input functions, so make it depend
    on INPUT_POLLDEV.
    
    ERROR: "input_register_polled_device" 
[drivers/platform/x86/oqo-wmi.ko] undefined!
    ERROR: "input_allocate_polled_device" 
[drivers/platform/x86/oqo-wmi.ko] undefined!
    ERROR: "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] 
undefined!
    ERROR: "input_unregister_polled_device" 
[drivers/platform/x86/oqo-wmi.ko] undefined!
    
    Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
    Acked-by: Matthew Garrett <mjg59@srcf.ucam.org>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: Len Brown <lenb@kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Len Brown <len.brown@intel.com>

commit 94c4b5977f33894cc316edf07c5cb72b5d193628
Author: Len Brown <len.brown@intel.com>
Date:   Fri Feb 6 23:06:38 2009 -0500

    oqo: dev_set_name()
    
    Signed-off-by: Len Brown <len.brown@intel.com>

commit 9c82cd255907ad639bed4ffc8fcaf1bd59badb50
Author: Matthew Garrett <mjg59@srcf.ucam.org>
Date:   Wed Dec 3 19:55:37 2008 +0000

    platform/x86: Add oqo-wmi driver for model 2 OQO backlight and rfkill 
control
    
    oqo-wmi provides a WMI-based interface to backlight and rfkill control 
on
    model 2 OQO devices. It was originally written by Brian Julin
    (<bri@abrij.org>) - I've ported it to the rfkill layer and tidied it 
up a
    little.
    
    Signed-off-by: Matthew Garrett <mjg@redhat.com>
    Signed-off-by: Len Brown <len.brown@intel.com>