* [PATCH] panasonic-laptop: beyond ARRAY_SIZE of pcc->keymap
[not found] ` <20090522021933.GA10832@linux-sh.org>
@ 2009-05-22 11:56 ` Roel Kluin
2009-05-27 22:14 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-05-22 11:56 UTC (permalink / raw)
To: Paul Mundt, len.brown, Andrew Morton; +Cc: linux-acpi
Do not go beyond ARRAY_SIZE of pcc->keymap
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
> Presumably you meant to send this to linux-acpi or linux-kernel instead
> of linux-sh ;-)
I was not sure, but linux-acpi is cc'ed now.
diff --git a/drivers/misc/panasonic-laptop.c b/drivers/misc/panasonic-laptop.c
index 4a1bc64..d82d1cc 100644
--- a/drivers/misc/panasonic-laptop.c
+++ b/drivers/misc/panasonic-laptop.c
@@ -515,7 +515,7 @@ static void acpi_pcc_generate_keyinput(struct pcc_acpi *pcc)
hkey_num = result & 0xf;
- if (hkey_num < 0 || hkey_num > ARRAY_SIZE(pcc->keymap)) {
+ if (hkey_num < 0 || hkey_num >= ARRAY_SIZE(pcc->keymap)) {
ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
"hotkey number out of range: %d\n",
hkey_num));
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] panasonic-laptop: beyond ARRAY_SIZE of pcc->keymap
2009-05-22 11:56 ` [PATCH] panasonic-laptop: beyond ARRAY_SIZE of pcc->keymap Roel Kluin
@ 2009-05-27 22:14 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2009-05-27 22:14 UTC (permalink / raw)
To: Roel Kluin; +Cc: Paul Mundt, Andrew Morton, linux-acpi
This patch already shipped in 2.6.29.
2b190e76def5233c542f6025b4a133b1d4bd1a37
"panasonic-laptop: fix X[ ARRAY_SIZE(X) ]"
thanks,
Len Brown, Intel Open Source Technology Center
On Fri, 22 May 2009, Roel Kluin wrote:
> Do not go beyond ARRAY_SIZE of pcc->keymap
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> > Presumably you meant to send this to linux-acpi or linux-kernel instead
> > of linux-sh ;-)
>
> I was not sure, but linux-acpi is cc'ed now.
>
> diff --git a/drivers/misc/panasonic-laptop.c b/drivers/misc/panasonic-laptop.c
> index 4a1bc64..d82d1cc 100644
> --- a/drivers/misc/panasonic-laptop.c
> +++ b/drivers/misc/panasonic-laptop.c
> @@ -515,7 +515,7 @@ static void acpi_pcc_generate_keyinput(struct pcc_acpi *pcc)
>
> hkey_num = result & 0xf;
>
> - if (hkey_num < 0 || hkey_num > ARRAY_SIZE(pcc->keymap)) {
> + if (hkey_num < 0 || hkey_num >= ARRAY_SIZE(pcc->keymap)) {
> ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
> "hotkey number out of range: %d\n",
> hkey_num));
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-27 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4A15B5CA.9060907@gmail.com>
[not found] ` <20090522021933.GA10832@linux-sh.org>
2009-05-22 11:56 ` [PATCH] panasonic-laptop: beyond ARRAY_SIZE of pcc->keymap Roel Kluin
2009-05-27 22:14 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).