linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] eeepc: fix selects (third time)
       [not found] <20090616165923.8ca4ddcb.sfr@canb.auug.org.au>
@ 2009-06-16 17:44 ` Randy Dunlap
  0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2009-06-16 17:44 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, LKML, Corentin Chary, Len Brown,
	ACPI Devel Maling List

linux-next still fails with various pci_*() undefined references, like:


ERROR: "pci_scan_slot" [drivers/pci/hotplug/cpqphp.ko] undefined!
ERROR: "pci_add_new_bus" [drivers/pci/hotplug/cpqphp.ko] undefined!
and
drivers/pci/hotplug/fakephp.c:55: error:implicit declaration of function 'pci_rescan_bus'

These are due to the eeepc driver's Kconfig selects.  Patch below
fixes them.

---
From: Randy Dunlap <randy.dunlap@oracle.com>

EEEPC_LAPTOP selects HOTPLUG_PCI.  This causes failures (build error below)
when CONFIG_HOTPLUG is not enabled, so additionally select HOTPLUG since
kconfig 'select' doesn't follow its dependency chain.
Also, only select HOTPLUG_PCI if PCI is already enabled.

drivers/pci/hotplug/fakephp.c:55: error: implicit declaration of function 'pci_rescan_bus'
ERROR: "pci_scan_slot" [drivers/pci/hotplug/pciehp.ko] undefined!
ERROR: "pci_scan_bridge" [drivers/pci/hotplug/pciehp.ko] undefined!
ERROR: "pci_scan_slot" [drivers/pci/hotplug/pci_hotplug.ko] undefined!
ERROR: "pci_add_new_bus" [drivers/pci/hotplug/pci_hotplug.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Corentin Chary <corentincj@iksaif.net>
---
 drivers/platform/x86/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20090604.orig/drivers/platform/x86/Kconfig
+++ linux-next-20090604/drivers/platform/x86/Kconfig
@@ -340,7 +340,8 @@ config EEEPC_LAPTOP
 	depends on RFKILL || RFKILL = n
 	select BACKLIGHT_CLASS_DEVICE
 	select HWMON
-	select HOTPLUG_PCI
+	select HOTPLUG
+	select HOTPLUG_PCI if PCI
 	---help---
 	  This driver supports the Fn-Fx keys on Eee PC laptops.
 	  It also adds the ability to switch camera/wlan on/off.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-16 17:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20090616165923.8ca4ddcb.sfr@canb.auug.org.au>
2009-06-16 17:44 ` [PATCH -next] eeepc: fix selects (third time) Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).