From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux acpi <linux-acpi@vger.kernel.org>
Subject: [PATCH] ACPI fan: fix memleak on acpi_fan_add_fs() failure
Date: Sun, 13 Sep 2009 11:28:30 +0100 [thread overview]
Message-ID: <4AACC94E.9040208@tuffmail.co.uk> (raw)
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
---
drivers/acpi/fan.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
index 947556e..eb1511e 100644
--- a/drivers/acpi/fan.c
+++ b/drivers/acpi/fan.c
@@ -283,13 +283,17 @@ static int acpi_fan_add(struct acpi_device *device)
result = acpi_fan_add_fs(device);
if (result)
- goto end;
+ goto unregister;
printk(KERN_INFO PREFIX "%s [%s] (%s)\n",
acpi_device_name(device), acpi_device_bid(device),
!device->power.state ? "on" : "off");
- end:
+unregister:
+ sysfs_remove_link(&device->dev.kobj, "thermal_cooling");
+ sysfs_remove_link(&cdev->device.kobj, "device");
+ thermal_cooling_device_unregister(cdev);
+end:
return result;
}
next reply other threads:[~2009-09-13 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 10:28 Alan Jenkins [this message]
2009-09-14 1:09 ` [PATCH] ACPI fan: fix memleak on acpi_fan_add_fs() failure ykzhao
2009-09-14 7:49 ` Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AACC94E.9040208@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox