From: Stefan Bader <stefan.bader@canonical.com>
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH][RESEND] acerhdf: Limit modalias matching to supported
Date: Mon, 09 Nov 2009 09:48:01 +0100 [thread overview]
Message-ID: <4AF7D741.1040607@canonical.com> (raw)
In-Reply-To: <1256221616-22577-1-git-send-email-stefan.bader@canonical.com>
Len,
could you please apply the patch mentioned or help me to understand
what I need to do, in order to correctly submit them?
Thanks,
Stefan
Stefan Bader wrote:
> Inlined patch version
>
> -Stefan
>
> From 230e81c3440cdfc5f931755cece4f1181a3b1374 Mon Sep 17 00:00:00 2001
> From: Stefan Bader <stefan.bader@canonical.com>
> Date: Mon, 28 Sep 2009 17:11:29 +0000
> Subject: [PATCH] acerhdf: Limit modalias matching to supported boards
>
> BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958
>
> The module alias currently matches any Acer computer but when loaded the
> BIOS checks will only succeed on Aspire One models. This causes a invalid
> BIOS warning for all other models (seen on Aspire 4810T).
> This is not fatal but worries users that see this message. Limiting the
> moule alias to models starting with AOA or DOA for Packard Bell.
>
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> Acked-by: Borislav Petkov <petkovbb@gmail.com>
> Acked-by: Peter Feuerer <peter@piie.net>
> ---
> drivers/platform/x86/acerhdf.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index aa298d6..890976f 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -629,9 +629,10 @@ static void __exit acerhdf_exit(void)
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Peter Feuerer");
> MODULE_DESCRIPTION("Aspire One temperature and fan driver");
> -MODULE_ALIAS("dmi:*:*Acer*:*:");
> -MODULE_ALIAS("dmi:*:*Gateway*:*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
> +MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
> +MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:");
> +MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:");
> +MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:");
>
> module_init(acerhdf_init);
> module_exit(acerhdf_exit);
prev parent reply other threads:[~2009-11-09 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 12:05 [Fwd: Re: [PATCH] acerhdf: Limit modalias matching to supported boards] Stefan Bader
2009-10-05 12:05 ` Stefan Bader
2009-10-05 15:19 ` Bjorn Helgaas
2009-10-05 15:56 ` Stefan Bader
2009-10-05 16:02 ` Bjorn Helgaas
2009-10-05 16:41 ` [PATCH] acerhdf: Limit modalias matching to supported boards Peter Feuerer
2009-10-22 12:12 ` [PATCH][RESEND] " Stefan Bader
2009-10-22 12:23 ` Peter Feuerer
2009-10-22 14:26 ` [PATCH][RESEND] acerhdf: Limit modalias matching to supported Stefan Bader
2009-11-09 8:48 ` Stefan Bader [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF7D741.1040607@canonical.com \
--to=stefan.bader@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox