From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH] x86: make sure wakeup code is below 1M -v2 Date: Wed, 11 Nov 2009 23:20:15 -0800 Message-ID: <4AFBB72F.6070907@zytor.com> References: <4AF7D820.5040503@kernel.org> <200911091315.13151.rjw@sisk.pl> <4AFA210B.3020207@kernel.org> <1257930767.31183.113.camel@localhost.localdomain> <4AFB0B02.4050306@kernel.org> <1257988632.31183.134.camel@localhost.localdomain> <4AFB7D21.6050004@kernel.org> <1257997072.3888.4.camel@localhost.localdomain> <4AFB9B60.7010009@kernel.org> <1258010067.3802.11.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:49009 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbZKLHVF (ORCPT ); Thu, 12 Nov 2009 02:21:05 -0500 In-Reply-To: <1258010067.3802.11.camel@localhost.localdomain> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: ykzhao Cc: Yinghai Lu , "Rafael J. Wysocki" , Ingo Molnar , Thomas Gleixner , Len Brown , "linux-kernel@vger.kernel.org" , ACPI Devel Maling List , pm list On 11/11/2009 11:14 PM, ykzhao wrote: > > In this patch the find_e820_area is used in the > acpi_reserve_wakeup_memory, which is called after initializing the > bootmem allocator. > Can we still use the find_e820_area after the bootmem allocator is > initialized? Obviously not: the bootmem allocator now thinks it owns memory, and it wouldn't know not to allocate something that is later claimed by find_e820_area. Problem. > It seems that the bootmem bitmap is also found by using the > find_e820_area. But we don't update the reserved_early array any more. > Maybe we will get the overlap address with the bootmem bitmap for the > wakeup code. Not just the bitmap, but any bootmem allocation could conflict... -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.