From: chen gong <gong.chen@linux.intel.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>
Subject: Re: [PATCH 2/2] update mutex usage in aggregator driver
Date: Thu, 17 Dec 2009 12:52:31 +0800 [thread overview]
Message-ID: <4B29B90F.3020307@linux.intel.com> (raw)
In-Reply-To: <20091217005433.GA12894@sli10-desk.sh.intel.com>
On 2009-12-17 8:54, Shaohua Li wrote:
> On Mon, Dec 14, 2009 at 09:42:29AM +0800, Chen Gong wrote:
>> I have 2 issues.
>> 1. I consider thread creation and RR thread execution don't share the
>> global data, so the serialization execution is not necessary. It is
>> enough to use another different mutex to lock thread exectuion itself
>> when these threads running concurrently.
>> 2. part of sysfs interfaces doesn't need to own mutex with thread createion.
>> Though some data maybe are not identical, it is not a big deal.
> ACK the first patch.
> NACK this one. I don't see any reason we need two locks here. This isn't hot
> code path, fine-grained lock just makes thing complex.
>
> Thanks,
> Shaohua
>
I don't think so. Though it is not critical code path but it is kernel
code. It should be made more consideration.
next prev parent reply other threads:[~2009-12-17 4:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 1:42 [PATCH 0/2] aggregator device driver update Chen Gong
2009-12-14 1:42 ` [PATCH 1/2] fix some errors in aggregator device driver Chen Gong
2009-12-14 1:42 ` [PATCH 2/2] update mutex usage in aggregator driver Chen Gong
2009-12-17 0:54 ` Shaohua Li
2009-12-17 4:52 ` chen gong [this message]
2009-12-16 4:00 ` [PATCH 0/2] aggregator device driver update Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B29B90F.3020307@linux.intel.com \
--to=gong.chen@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox