* [PATCH] ACPI: Fix &&/|| confusion in acpi_evaluate_string() (in comment)
@ 2009-12-31 11:56 Roel Kluin
0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2009-12-31 11:56 UTC (permalink / raw)
To: Len Brown, linux-acpi, Andrew Morton, LKML
This always evaluates to true.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/acpi/utils.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
It's between an #if 0 ... #endif.
diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index 811fec1..3495b43 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -312,7 +312,7 @@ acpi_evaluate_string(acpi_handle handle,
element = (acpi_object *) buffer.pointer;
if ((element->type != ACPI_TYPE_STRING)
- || (element->type != ACPI_TYPE_BUFFER)
+ && (element->type != ACPI_TYPE_BUFFER)
|| !element->string.length) {
acpi_util_eval_error(handle, pathname, AE_BAD_DATA);
return AE_BAD_DATA;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-12-31 11:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-31 11:56 [PATCH] ACPI: Fix &&/|| confusion in acpi_evaluate_string() (in comment) Roel Kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).