From: Alexey Starikovskiy <aystarik@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Moore, Robert" <robert.moore@intel.com>,
Matthew Garrett <mjg@redhat.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Lin, Ming M" <ming.m.lin@intel.com>,
"Brown, Len" <len.brown@intel.com>
Subject: Re: [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs
Date: Thu, 25 Feb 2010 18:14:08 +0300 [thread overview]
Message-ID: <4B8693C0.4020701@gmail.com> (raw)
In-Reply-To: <201002200014.04936.rjw@sisk.pl>
Rafael J. Wysocki пишет:
> --- linux-2.6.orig/drivers/acpi/ec.c
> +++ linux-2.6/drivers/acpi/ec.c
> @@ -307,7 +307,11 @@ static int acpi_ec_transaction(struct ac
> pr_debug(PREFIX "transaction start\n");
> /* disable GPE during transaction if storm is detected */
> if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
> - acpi_disable_gpe(NULL, ec->gpe);
> + /*
> + * It has to be disabled at the hardware level regardless of the
> + * GPE reference counting, so that it doesn't trigger.
> + */
> + acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_DISABLE);
> }
>
EC should have non-shared GPE, according to spec. Thus, refcounting is
not needed here anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-02-25 15:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 21:23 [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs Moore, Robert
2010-02-19 23:14 ` Rafael J. Wysocki
2010-02-24 22:05 ` Moore, Robert
2010-02-25 15:14 ` Alexey Starikovskiy [this message]
2010-02-25 19:56 ` Rafael J. Wysocki
2010-02-19 23:18 ` Rafael J. Wysocki
2010-02-23 0:26 ` Jesse Barnes
2010-02-23 23:52 ` Rafael J. Wysocki
2010-02-24 22:26 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2010-02-17 22:35 [PATCH 0/8] PCI run-time PM support (rev. 4) Rafael J. Wysocki
2010-02-17 22:41 ` [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs Rafael J. Wysocki
2010-02-18 7:05 ` Jin Dongming
2010-02-18 20:01 ` Rafael J. Wysocki
2010-02-19 7:24 ` Jin Dongming
2010-02-19 21:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8693C0.4020701@gmail.com \
--to=aystarik@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mjg@redhat.com \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).