Hi Bjorn,

Thanks for the comments ...
> It looks like acpi_memhotplug can be compiled as a module, so
> shouldn't "mem_hotadd_auto=" be a module parameter?
>
>   

Good point -- I have changed this to a module parameter.

> Is it possible that a user would want to online memory for some
> hot-add events but not others?  If so, maybe the mem_hotadd_auto
> thing should also be in sysfs?
>   
Users are going to turn it on and keep it on.  To be honest, I've only 
included it because I found it useful while debugging cpu hot adds.

> Printks with constant text are one of my pet peeves because they don't
> give any clues for debugging.  Surely there's useful information we
> could include here, like the ACPI device info (maybe using dev_err()),
> the memory range, etc?
>   

Fixed -- I was taking a hint from the surrounding code and not including 
the memory range, but I agree with you that more info is better. I've 
changed this to display the memory range that failed.

P.

D'oh!  Fixed.


> Bjorn
>